Skip to content

Use extend when creating the lint pass constructors #15994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+414 −382
Open

Use extend when creating the lint pass constructors #15994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
369c9f4
Register early passes with `extend` instead of `register_early_pass`.
Jarcho Oct 31, 2025
7176f3a
Register late passes with `extend` instead of `register_late_pass`.
Jarcho Oct 31, 2025
f5e4a01
Update `dev new_lint` to add passes to each array.
Jarcho Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions clippy_dev/src/new_lint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,18 +157,19 @@ fn add_lint(lint: &LintData<'_>, enable_msrv: bool) -> io::Result<()> {
let path = "clippy_lints/src/lib.rs";
let mut lib_rs = fs::read_to_string(path).context("reading")?;

let comment_start = lib_rs.find("// add lints here,").expect("Couldn't find comment");
let ctor_arg = if lint.pass == Pass::Late { "_" } else { "" };
let lint_pass = lint.pass;
let (comment, ctor_arg) = if lint.pass == Pass::Late {
("// add late passes here", "_")
} else {
("// add early passes here", "")
};
let comment_start = lib_rs.find(comment).expect("Couldn't find comment");
let module_name = lint.name;
let camel_name = to_camel_case(lint.name);

let new_lint = if enable_msrv {
format!(
"store.register_{lint_pass}_pass(move |{ctor_arg}| Box::new({module_name}::{camel_name}::new(conf)));\n ",
)
format!("Box::new(move |{ctor_arg}| Box::new({module_name}::{camel_name}::new(conf))),\n ",)
} else {
format!("store.register_{lint_pass}_pass(|{ctor_arg}| Box::new({module_name}::{camel_name}));\n ",)
format!("Box::new(|{ctor_arg}| Box::new({module_name}::{camel_name})),\n ",)
Copy link
Member

@blyxyas blyxyas Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why those spaces are there? (After \n)

};

lib_rs.insert_str(comment_start, &new_lint);
Expand Down
Loading