Don't lint assertions_on_constants on any const assertions
#12840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
the
S-waiting-on-review
dswij
reviewed
May 24, 2024
tesuji
changed the title
assertions-on-constants when it is const assertionsassertions-on-constants on any const assertions
Contributor
Author
|
It's been 2 weeks without new review |
tesuji
force-pushed
the
const-asserts
branch
2 times, most recently
from
e6cb5a2 to
7b06d72
Compare
Contributor
Author
|
Build fail as expected. In summary: So waiting for next rustup... Edit: |
- remove now dead code in ASSERTIONS_ON_CONSTANTS cc rust-lang#11966 - Partially revert "ignore `assertions-on-constants` in const contexts" This reverts commit c7074de.
Contributor
Author
|
rerolling r? @llogiq |
Contributor
|
Looks ok to me. Thank you for staying the course. @bors r+ |
Contributor
Contributor
Contributor
|
💔 Test failed - checks-action_test |
Contributor
Author
|
Blessed the test after rustup ! |
tesuji
changed the title
assertions-on-constants on any const assertionsassertions_on_constants on any const assertions
|
Can the build be rerun? I just ran into this issue. |
Contributor
Author
|
@llogiq Could we |
Contributor
|
Ok, here goes nothing: @bors retry |
Contributor
|
Ah, that won't work. I need to @bors r+ again |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12816
close #12847
cc #12817
changelog: Fix false positives in consts for
assertions_on_constantsandunnecessary_operation.