Skip to content

Actually tell browsers that cacheable assets are immutable #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2025
Merged

Actually tell browsers that cacheable assets are immutable #2986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/web/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ pub static SHORT: HeaderValue = HeaderValue::from_static("max-age=60");
pub static NO_STORE_MUST_REVALIDATE: HeaderValue =
HeaderValue::from_static("no-cache, no-store, must-revalidate, max-age=0");

pub static FOREVER_IN_CDN_AND_BROWSER: HeaderValue = HeaderValue::from_static("max-age=31104000");
pub static FOREVER_IN_CDN_AND_BROWSER: HeaderValue =
HeaderValue::from_static("public, max-age=31104000, immutable");

/// defines the wanted caching behaviour for a web response.
#[derive(Debug, Clone)]
Expand Down Expand Up @@ -120,7 +121,10 @@ mod tests {
CachePolicy::NoStoreMustRevalidate,
Some("no-cache, no-store, must-revalidate, max-age=0")
)]
#[test_case(CachePolicy::ForeverInCdnAndBrowser, Some("max-age=31104000"))]
#[test_case(
CachePolicy::ForeverInCdnAndBrowser,
Some("public, max-age=31104000, immutable")
)]
#[test_case(CachePolicy::ForeverInCdn, None)]
#[test_case(
CachePolicy::ForeverInCdnAndStaleInBrowser,
Expand Down
Loading