Skip to content

Simplify version handling of browser-ui-test and update to version 0.21.3 #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2025
Merged

Simplify version handling of browser-ui-test and update to version 0.21.3 #2910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions dockerfiles/Dockerfile-gui-tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ RUN apt-get install -y \
xdg-utils \
wget

# Install rust
RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | bash -s -- -y --default-toolchain nightly --no-modify-path --profile minimal
ENV PATH="/root/.cargo/bin:${PATH}"

RUN curl -sL https://nodejs.org/dist/v22.13.1/node-v22.13.1-linux-x64.tar.xz | tar -xJ
ENV PATH="/node-v22.13.1-linux-x64/bin:${PATH}"
ENV NODE_PATH="/node-v22.13.1-linux-x64/lib/node_modules/"
Expand All @@ -69,13 +65,13 @@ WORKDIR /build

RUN mkdir out

COPY ../package.json /build/package.json

# For now, we need to use `--unsafe-perm=true` to go around an issue when npm tries
# to create a new folder. For reference:
# https://github.com/puppeteer/puppeteer/issues/375
#
# We also specify the version in case we need to update it to go around cache limitations.
RUN npm install -g browser-ui-test@0.21.1 --unsafe-perm=true

EXPOSE 3000
RUN npm install --unsafe-perm=true --loglevel verbose --force

CMD ["node", "/build/out/gui-tests/tester.js"]
3 changes: 2 additions & 1 deletion dockerfiles/run-gui-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,12 @@ fi

. .env

set +e # We disable the "exit right away if command failed" setting.
cargo run -- start-web-server &
SERVER_PID=$!

# status="docker run . -v `pwd`:/build/out:ro gui_tests"
docker compose run gui_tests
docker compose run --rm gui_tests
status=$?
kill $SERVER_PID
exit $status
6 changes: 6 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"name": "deps",
"dependencies": {
"browser-ui-test": "^0.21.3"
}
}
Loading