-
Notifications
You must be signed in to change notification settings - Fork 293
Add Socks5 Proxy #249
base: master
Are you sure you want to change the base?
Add Socks5 Proxy #249
Conversation
This PR uses the `proxy` feature of rust-jsonrpc to create a http transport via sock5 proxy. Which can be activated using the `proxy` feature of this library. - Update Cargo.toml to include `proxy` feature. - Add a new `new_with_proxy()` constructor for client.
5e3ed71 to
e3d4df7
Compare
This adds the previously added `proxy` feature into integration test for testing the proxy functionality.
e3d4df7 to
9a430e0
Compare
|
I have been able to connect to a For anyone wanna try it out..
Observe RPC response |
|
Now that I am a bit confident that all of this is working, so taking this PR out of draft.. Any suggestion or modification for ways forward to get this merged would be very welcome.. |
|
@rajarshimaitra we'll definitely need to get a release of I spent some time working on this but got rabbit-holed trying to mock out the code so I could run fuzztests against it. |
Okay.. Do I need to update something in the jsonrpc repo for this part of the logic? |
|
@rajarshimaitra we need to get apoelstra/rust-jsonrpc#76 finished and in, adn then we should be good to go. |
|
Just checking in to see if there are any plans to get this PR merged in? |
This is an attempt to complete the proxy support for bitcoin core json rpc. After apoelstra/rust-jsonrpc@7c94adf the rust-jsonrpc http transport optionally takes in a proxy configuration with a
proxyfeature flag.This PR accomodates that change into this library.
Goal is to connect with a bitcoin core RPC port via Tor proxy, which is useful to connect a wallet to a home node RPC end point for syncing, which usually do not have static IP address.
This PR is draft because I can't get it to connect successfully to a regtest RPC endpoint. I have reported my attempts for that in #246 ..
Also this PR currently builds on an unreleased version of rust-jsonrpc as the new proxy feature isn't released yet.
Intent of this PR is for initial comment and any help in testing out actual RPC communication via Tor.