jsonrpc: Depend on bitreq
#399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
push-wmmwntomupqn
branch
from
11d27c8 to
2013b42
Compare
tcharding
force-pushed
the
push-wmmwntomupqn
branch
2 times, most recently
from
2ea4b01 to
11d9d3e
Compare
Collaborator
|
Could address #406 as part of this PR. The two cases left I can see are: |
99c948c Re-implement json-using-serde feature (Tobin C. Harding) 1251953 Replace stale docs reference to minreq (Tobin C. Harding) Pull request description: This feature was removed when we gutted `minreq` after forking it. Turns out we need it to be able to use `bitreq` in `jsonrpc`. Re-implement the feature by copying code from `minreq`. Close: rust-bitcoin#393 ACKs for top commit: oleonardolima: tACK 99c948c jamillambert: ACK 99c948c Tree-SHA512: 2e22881566fd3d75e0edb70567dac0b1ed9ce66720511dcead888b2b7686fc89fb1f6bce3bd490f91997e9ade88b0665b00679c79bcef35205c6ce1117306faf
Stale name since we renamed the crate to `bitreq`. Fix a few instances of `s/minreq/bitreq` missed when forking.
Missed during crate rename.
tcharding
force-pushed
the
push-wmmwntomupqn
branch
from
11d9d3e to
caf7145
Compare
Collaborator
|
grepped for |
Should have been done during the minreq -> bitreq rename.
We just forked `minreq` into this repository to create an HTTP crate that is specifically designed to be used by Bitcoin projects. As such we called it `bitreq`. Depend on the local `bitreq` crate instead of `minreq`. Done directly in `node` and `jsonrpc`. Indirectly in `client`, including rename of a million macros that have `minreq` in the name.
tcharding
force-pushed
the
push-wmmwntomupqn
branch
from
caf7145 to
4ef980d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just forked
minreqinto this repository to create an HTTP crate that is specifically designed to be used by Bitcoin projects. As such we called itbitreq.Depend on the local
bitreqcrate instead ofminreq.