Add git committers file #396
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a CODEOWNERS file to the project. - Andrew for `jsonrpc` because its his crate. - Jamil for `types` and `client` because he wrote much of the code it `types`. - Ricardo for `node` because its his crate. - Leo for `bitreq` because he offered to help maintain in at the Rust Bitcoin Summit. This PR will need explicit acks from each of these devs please.
jamillambert
approved these changes
Oct 27, 2025
Collaborator
jamillambert
left a comment
jamillambert
left a comment
There was a problem hiding this comment.
LGTM assuming Require review from Code Owners is off.
ACK 748d19c
RCasatta
approved these changes
Oct 27, 2025
Member
Author
Looks like this defaults to off and I have not turned it on. |
Member
Author
|
Needs an ack from @apoelstra for |
Member
Author
|
@jamillambert I just update the description because I originally omitted listing you for |
tcharding
added a commit
to tcharding/corepc
that referenced
this pull request
Oct 27, 2025
The `corepc` repo is for all things integration testing. Also it provides `bitreq` (HTTP crate), and `corepc-types` (Bitcoin Core JSONRPC types). When integration testing some users (eg `bdk`) use `electrsd` along side `corepc-node` (formerly `bitcoind`). `electrsd` depends on `corepc-node` and every time we release `corepc-node` we have to do a release of `electrsd`. Having them in separate repositories causes friction and makes additional work. Instead we can put them together to hopefully make everyone's life easier (well mine and Ricardo's anyway). Note that `bitcoind` was written by Ricardo. I re-named it, a move I'm now regretting because of the original symmetry with `electrsd`. This import has the blessing of Ricardo and needs an explicit ACK from him before merging. When the CODEOWNERS file is added (rust-bitcoin#396) it should include him as owner of this crate. Import the `electrsd` crate from https://github.com/RCasatta/electrsd/ While HEAD is at commit hash: dc88d81520c9ec507fc830b88a3b92a034dbaf93 `dc88d81: bump version 0.36.0 -> 0.36.1`
Open
tcharding
added a commit
to tcharding/corepc
that referenced
this pull request
Oct 27, 2025
The `corepc` repo is for all things integration testing. Also it provides `bitreq` (HTTP crate), and `corepc-types` (Bitcoin Core JSONRPC types). When integration testing some users (eg `bdk`) use `electrsd` along side `corepc-node` (formerly `bitcoind`). `electrsd` depends on `corepc-node` and every time we release `corepc-node` we have to do a release of `electrsd`. Having them in separate repositories causes friction and makes additional work. Instead we can put them together to hopefully make everyone's life easier (well mine and Ricardo's anyway). Note that `bitcoind` was written by Ricardo. I re-named it, a move I'm now regretting because of the original symmetry with `electrsd`. This import has the blessing of Ricardo and needs an explicit ACK from him before merging. When the CODEOWNERS file is added (rust-bitcoin#396) it should include him as owner of this crate. Import the `electrsd` crate from https://github.com/RCasatta/electrsd/ While HEAD is at commit hash: dc88d81520c9ec507fc830b88a3b92a034dbaf93 `dc88d81: bump version 0.36.0 -> 0.36.1`
Member
Author
Member
Author
|
@apoelstra can you ack this please as crate owner of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CODEOWNERS file to the project.
jsonrpcbecause its his crate.typesandclientbecause he wrote much of the code ittypes.nodebecause its his crate.bitreqbecause he offered to help maintain in at the Rust Bitcoin Summit.bitreq, no reason other than to elicit his help.This PR will need explicit acks from each of these devs please.
cc @apoelstra, @jamillambert, @RCasatta, @oleonardolima