update ground-object-hider

[umer-rs]

fix startup crash & make work without gpu plugin

reduced diff due to some reverting:
https://github.com/dey0/pluginhub-plugins/compare/501c37f252ce22a64ee5742708b1d39f6b6ed9e6..120d94799b987715053429466c16c981b46efd8a

[runelite-github-app]

object-hider: b70abbc8f98d3b00b7091ed0cadc0b2fe98f4e41..120d94799b987715053429466c16c981b46efd8a

[runelite-github-app]

Internal use only: Reviewer details Maintainer details

[LlemonDuck]

your unloading of stuff is not sound, you need to be discarding of GameObject references as soon as they're invalidated. Waiting until they go a certain distance away is not sufficient.

There are only two cases you need to worry about:

• onGameObjectDespawned -> remove
  • you don't need to do any comparisons, just referential equality is fine (Set#remove, HashMap#remove, eventObj == storedObj) are all sufficient
• onWorldViewUnloaded -> remove all objects from that WorldView
  • e.g. Set#removeIf(obj -> obj.getWorldView() == event.getWorldView())

[umer-rs]

Is it fine if this just went in, for this is how the plugin used to work. It will restore functionality without requiring GPu plugin.

I'll cook up a fix when I have more time wrt this and the discussion in development channel a few days ago.

[LlemonDuck]

No, you're holding onto GameObjects beyond their lifetime which can cause instability in the client and possibly crashes. The change I'm requesting is not a significant lift.

Replace hiddenObjects with a Set<GameObject> and the rest should shake out