Fix false negative for RSpec/DescribedClass with constant base #2140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovro-bikic
commented
Nov 27, 2025
Comment on lines
+53
to
+56
| # # good | ||
| # describe MyClass do | ||
| # subject { described_class::CONSTANT } | ||
| # end |
Contributor
Author
There was a problem hiding this comment.
I added this because I think a "good" example was missing here
lovro-bikic
commented
Nov 27, 2025
Comment on lines
+492
to
+500
| it 'ignores parenthesized namespaces within modules - begin_types' do | ||
| expect_no_offenses(<<~RUBY) | ||
| module Foo | ||
| describe MyClass do | ||
| subject { (MyNamespace)::MyClass } | ||
| end | ||
| end | ||
| RUBY | ||
| end |
Contributor
Author
There was a problem hiding this comment.
This test is currently failing on master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
RSpec/DescribedClasswon't register offenses when described class uses a constant base and the reference doesn't, and vice versa. For example:This PR adds handling of constant bases to this cop.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).