Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/flutter_hooks/lib/src/expansion_tile_controller.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,17 @@ class _ExpansibleControllerHook extends Hook<ExpansibleController> {

class _ExpansibleControllerHookState
extends HookState<ExpansibleController, _ExpansibleControllerHook> {
final controller = ExpansibleController();
final _controller = ExpansibleController();

@override
String get debugLabel => 'useExpansibleController';

@override
ExpansibleController build(BuildContext context) => controller;
ExpansibleController build(BuildContext context) => _controller;

@override
void dispose() {
_controller.dispose();
super.dispose();
}
}
28 changes: 28 additions & 0 deletions packages/flutter_hooks/test/use_expansible_controller_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -78,5 +78,33 @@ void main() {
controller.collapse();
expect(controller.isExpanded, false);
});

testWidgets('check ExpansibleController gets disposed', (tester) async {
late ExpansibleController controller;
await tester.pumpWidget(MaterialApp(
home: Scaffold(
body: HookBuilder(builder: (context) {
controller = useExpansibleController();
return ExpansionTile(
controller: controller,
title: const Text('Expansion Tile'),
);
}),
),
));

await tester.pumpWidget(const SizedBox());

expect(
() => controller.addListener(() {}),
throwsA(
isFlutterError.having(
(e) => e.message,
'message',
contains('disposed'),
),
),
);
});
});
}