Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 24, 2025

Handle types not being double are just not published now.

I tried to make cast_to_double() reusable, I did not find a better place to add it.


This is an automatic backport of pull request #2633 done by Mergify.

(cherry picked from commit fd12e90)

# Conflicts:
#	hardware_interface/include/hardware_interface/handle.hpp
#	hardware_interface/include/hardware_interface/hardware_info.hpp
@mergify mergify bot added the conflicts label Nov 24, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Nov 24, 2025

Cherry-pick of fd12e90 has failed:

On branch mergify/bp/jazzy/pr-2633
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit fd12e90.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   hardware_interface/test/test_handle.cpp
	modified:   hardware_interface_testing/test/test_components/test_actuator.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hardware_interface/include/hardware_interface/handle.hpp
	both modified:   hardware_interface/include/hardware_interface/hardware_info.hpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.35%. Comparing base (1f75c84) to head (e3d8f86).
⚠️ Report is 1 commits behind head on jazzy.

Files with missing lines Patch % Lines
...re_interface/include/hardware_interface/handle.hpp 73.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2855      +/-   ##
==========================================
+ Coverage   89.32%   89.35%   +0.02%     
==========================================
  Files         152      152              
  Lines       17892    17938      +46     
  Branches     1457     1459       +2     
==========================================
+ Hits        15982    16028      +46     
  Misses       1335     1335              
  Partials      575      575              
Flag Coverage Δ
unittests 89.35% <91.83%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rface/include/hardware_interface/hardware_info.hpp 92.85% <100.00%> (+12.08%) ⬆️
hardware_interface/test/test_handle.cpp 98.65% <100.00%> (+0.17%) ⬆️
...ace_testing/test/test_components/test_actuator.cpp 88.73% <100.00%> (ø)
...re_interface/include/hardware_interface/handle.hpp 89.51% <73.33%> (-0.58%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit c127451 into jazzy Nov 25, 2025
12 of 13 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-2633 branch November 25, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants