Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 24, 2025

Handle types not being double are just not published now.

I tried to make cast_to_double() reusable, I did not find a better place to add it.


This is an automatic backport of pull request #2633 done by Mergify.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.45%. Comparing base (b0dac2d) to head (bbfe1c2).
⚠️ Report is 2 commits behind head on kilted.

Files with missing lines Patch % Lines
...re_interface/include/hardware_interface/handle.hpp 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           kilted    #2854      +/-   ##
==========================================
+ Coverage   89.44%   89.45%   +0.01%     
==========================================
  Files         152      152              
  Lines       17983    18030      +47     
  Branches     1466     1468       +2     
==========================================
+ Hits        16084    16128      +44     
- Misses       1312     1314       +2     
- Partials      587      588       +1     
Flag Coverage Δ
unittests 89.45% <90.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rface/include/hardware_interface/hardware_info.hpp 92.85% <100.00%> (+12.08%) ⬆️
hardware_interface/test/test_handle.cpp 98.68% <100.00%> (+0.16%) ⬆️
...ace_testing/test/test_components/test_actuator.cpp 88.73% <100.00%> (ø)
...re_interface/include/hardware_interface/handle.hpp 85.92% <71.42%> (-0.14%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 8e13d86 into kilted Nov 24, 2025
13 of 14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/kilted/pr-2633 branch November 24, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants