Refactor test setup to use PathSubstitution

[shrujanus]

Refactored the ./controller_manager/test/test_ros2_control_node_launch.py file to use PathSubstitution and removed the unnecessary variables in the import.

[mergify]

@shrujanus, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to humble, but it must be in master
to have these changes reflected into new distributions.

[christophfroehlich]

Thanks, but please Please open a PR against master branch.

[christophfroehlich]

I think we still need this for @pytest.mark.launch_test?

[christophfroehlich]

do we use this?

[shrujanus]

Thanks, but please Please open a PR against master branch.

Sorry about that! Should I close this PR and request another one to master? or is there a way to change that right here?

[christophfroehlich]

As you like. you also can rebase your commit on top of master, force push, and change the base branch of this PR.

[shrujanus]

As you like. you also can rebase your commit on top of master, force push, and change the base branch of this PR.

The reason I used the humble branch is that I wasn’t able to build the project when I was on master. I’m running ROS 2 Humble on Ubuntu 22.04, so I switched to the humble branch because it matches my ROS distribution and compiles correctly.

Is it common for developers to create branches off their ROS distribution branch (e.g., humble) and later rebase onto master? Or is the expectation that the master branch should compile across all supported ROS distributions?

[christophfroehlich]

As you like. you also can rebase your commit on top of master, force push, and change the base branch of this PR.

The reason I used the humble branch is that I wasn’t able to build the project when I was on master. I’m running ROS 2 Humble on Ubuntu 22.04, so I switched to the humble branch because it matches my ROS distribution and compiles correctly.

Is it common for developers to create branches off their ROS distribution branch (e.g., humble) and later rebase onto master? Or is the expectation that the master branch should compile across all supported ROS distributions?

ros2_control stack's rolling version is compatible with humble distro, see development version in the docs.
A more elegant developer workflow might be using a docker image, maybe in a vscode devcontainer setup, and develop directly on rolling. You can use the docker files here as a basis, or use one of the several resources for devcontainer setups. I use this one btw.