Improve TASImage::SavePrimitive, fix stressGraphics
#20422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Do not resize stored image, there is no limitation for images 2. Use same logic for created variable 3. Correctly store image attributes
Make it similar to TObject::Clone() signature
Loaded image was not deleted. Instead loading same image multiple times - clone it Use tutorials dir
It is more reliable way as using $ROOTSYS shell variable
All files read from tutorials dir - so use gROOT->GetTutorialDir()
Test Results 22 files 22 suites 3d 17h 36m 10s ⏱️ Results for commit 8889857. |
couet
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asimagevariable name, handle it as in all other classesTImage::Clone(const char *)signature similar toTObject::Clone(const char *="")where default args is definedstressGraphicstimage testgROOT->GetTutorialDir()