Skip to content

Clean code s1e1 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Clean code s1e1 #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
75099b0
fix(basic-1.1, basic-3.5) indentation and indentation in block
sergei404 Oct 20, 2025
aef6e10
fix(basic-1.2) use lowercase
sergei404 Oct 20, 2025
b2e7b37
fix(basic-1.3) change quotes
sergei404 Oct 20, 2025
297f43f
fix(basic-2.1) formatting
sergei404 Oct 20, 2025
dd3b400
fix(basic-2.2) add doctype
sergei404 Oct 20, 2025
3bcf7cf
fix(basic-2.3) delete named character references
sergei404 Oct 20, 2025
178ce38
fix(basic-2.4) delete type attribute
sergei404 Oct 20, 2025
236e531
fix(basic-2.5) line wrapping
sergei404 Oct 20, 2025
3f691e4
fix(basic-3.1, basic-3.2, basic-3.3, basic-3.4) single style for sele…
sergei404 Oct 20, 2025
e65fba5
fix(basic-3.6) add space after property name
sergei404 Oct 20, 2025
7611182
fix(basic-3.7) semicolon after properties
sergei404 Oct 20, 2025
7040616
fix(basic-3.8) separate selectors and properties
sergei404 Oct 20, 2025
2271dfe
fix(advanced-1.1) semantics
sergei404 Oct 20, 2025
53e58c7
fix(advanced-1.2) add alt attribute
sergei404 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 58 additions & 15 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,62 @@
<!DOCTYPE html>
<html>
<HEAD><title>Todo App</title>
<link href='https://fonts.googleapis.com/css?family=Lato:300,400,700' rel='stylesheet' type='text/css'>
<link rel="stylesheet" href="style.css" type="text/css" MEDIA="screen" charset="utf-8">
</HEAD>

<head>
<title>Todo App</title>
<link href="https://fonts.googleapis.com/css?family=Lato:300,400,700" rel="stylesheet" type="text/css">
<link rel="stylesheet" href="style.css" media="screen" charset="utf-8">
</head>

<body>
<div class="aaa"><img src="./eisenhower-matrix.jpg"><a class='more_inf' href="https://goal-life.com/page/method/matrix-eisenhower">Want more details&quest;</a></div>
<div class="centered-main-page-element"><p id='topSectionForAddingElementToList'><label for="new-task">Add Item</label><div class="task-row-wrapper"><input id='new-task'class="task" type="text"><button>Add</button></div>
</p><h3>Todo</h3>
<ul id='incompleteTasks'>
<li><input type='checkbox'><label class="task">Pay Bills</label><input type="text" class="task"><button class="edit">Edit</button><button class="delete"><img src="./remove.svg"></button></li>
<li class="editMode"><input type="checkbox"><label class="task">Go Shopping</label><input type="text" value="Go Shopping" class="task"><button class='edit'>Save</button><button class="delete"><img src="./remove.svg"></button></li>
</ul><h3>Completed</h3><ul id="completed-tasks"><li><input type="checkbox" checked><label class="task">See the Doctor</label><input type="text" class="task"><button class="edit">Edit</button><button class="delete"><img src="./remove.svg"></button>
</li>
</ul>
</div>
<script type="text/javascript" SRC="app.js"></script>
<div class="banner">
<img class="banner__image" src="./eisenhower-matrix.jpg" alt="banner photo">
<a class='banner__link' href="https://goal-life.com/page/method/matrix-eisenhower">
Want more details?
</a>
</div>
<article class="main-page">
<section id="adding-element">
<label for="new-task" class="main-page__task-label">Add Item</label>
<div class="main-page__wrapper">
<input id="new-task" class="main-page__new-task" type="text">
<button class="main-page__btn">Add</button>
</div>
</section>
<h3 class="main-page__title">Todo</h3>
<ul id="incomplete-tasks" class="main-page__list-incomplete main-page__list">
<li class="main-page__item">
<input type="checkbox" class="main-page__check">
<label class="main-page__label">Pay Bills</label>
<input type="text" class="main-page__input">
<button class="main-page__edit">Edit</button>
<button class="main-page__delete">
<img src="./remove.svg" alt="remove icon">
</button>
</li>
<li class="main-page__edit-task main-page__item">
<input type="checkbox" class="main-page__check">
<label class="main-page__label">Go Shopping</label>
<input type="text" value="Go Shopping" class="main-page__input">
<button class="main-page__edit">Save</button>
<button class="main-page__delete">
<img src="./remove.svg" alt="remove icon">
</button>
</li>
</ul>
<h3 class="main-page__title">Completed</h3>
<ul id="completed-tasks" class="main-page__list-complete main-page__list">
<li class="main-page__item">
<input type="checkbox" checked class="main-page__check">
<label class="main-page__label">See the Doctor</label>
<input type="text" class="main-page__input">
<button class="main-page__edit">Edit</button>
<button class="main-page__delete">
<img src="./remove.svg" alt="remove icon">
</button>
</li>
</ul>
</article>
<script src="app.js"></script>
</body>

</html>
220 changes: 115 additions & 105 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,148 +1,158 @@
/* Basic Style */
body {
background-color: #f8f8f8;
color: #333;
font-family: Lato, sans-serif;
background-color: #f8f8f8;
color: #333;
font-family: Lato, sans-serif;
}
.aaa {
.banner {
width: 500px;
margin: 0 auto;
display: block;
text-align: right;
}
.aaa img {
.banner .banner__image {
width: 100%;
}
.aaa .more_inf {
.banner__link {
font-family: fantasy, cursive;
}

@media (max-width:768px) {
.aaa { text-align: center;
}
}
.centered-main-page-element {
display: block;
width: 500px;
margin: 0 auto 0;
}
.task {
width: 56%;
display: inline-block;
flex-grow: 1
}
.task-row-wrapper {
display: flex;
@media (max-width: 768px) {
.banner {
text-align: center;
}
}
.main-page {
display: block;
width: 500px;
margin: 0 auto 0;
}
.main-page__new-task,
.main-page__label,
.main-page__input {
width: 56%;
display: inline-block;
flex-grow: 1
}
.main-page__wrapper {
display: flex;
}
ul {
margin:0;
padding: 0px;
}
li, h3 {
list-style:none;
}
input,button{
outline:none;
}
button {
background: none;
border: 0px;
color: #888;
font-size: 15px;
width: 60px;
font-family: Lato, sans-serif;
cursor: pointer;
}
button:hover {
color: #3a3A3a;
margin: 0;
padding: 0px;
}
li,
h3 {
list-style: none;
}
input,
button{
outline:none;
}
.main-page__btn,
.main-page__edit,
.main-page__delete {
background: none;
border: 0px;
color: #888;
font-size: 15px;
width: 60px;
font-family: Lato, sans-serif;
cursor: pointer;

&:hover {
color: #3a3a3a;
}
}

/* Heading */
h3,
label[for='new-task'] {
color: #333;
font-weight: 700;
font-size: 15px;
border-bottom: 2px solid #333;
padding: 30px 0 10px;
margin: 0;
text-transform: uppercase;
}
input[type="text"] {
margin: 0;
font-size: 18px;
line-height: 18px;
height: 21px;
padding: 0 9px;
border: 1px solid #dDd;
background: #FFF;
border-radius: 6px;
font-family: Lato, sans-serif;
color: #888;
}
input[type="text"]:focus {
.main-page__title,
.main-page__task-label {
color: #333;
font-weight: 700;
font-size: 15px;
border-bottom: 2px solid #333;
padding: 30px 0 10px;
margin: 0;
text-transform: uppercase;
}
.main-page__new-task,
.main-page__input {
margin: 0;
font-size: 18px;
line-height: 18px;
height: 21px;
padding: 0 9px;
border: 1px solid #ddd;
background: #fff;
border-radius: 6px;
font-family: Lato, sans-serif;
color: #888;

&:focus {
color: #333;
}
}

/* New Task */
label[for='new-task'] {
display: block;
margin: 0 0 20px;
.main-page__task-label {
display: block;
margin: 0 0 20px;
}
input#new-task {
width: 318px;
.main-page__new-task {
width: 318px;
}

/* Task list */
li {
overflow: hidden;
padding: 20px 0;
border-bottom: 1px solid #eee;

display: flex;
justify-content: space-between;
align-items: center;
.main-page__item {
overflow: hidden;
padding: 20px 0;
border-bottom: 1px solid #eee;
display: flex;
justify-content: space-between;
align-items: center;
}
li > * {
vertical-align: middle;
.main-page__item > * {
vertical-align: middle;
}

li > input[type="checkbox"] {
margin: 0 10px;
.main-page__item > .main-page__check {
margin: 0 10px;
}
li > label {
padding-left: 10px;
box-sizing: border-box;
font-size: 18px;
width: 226px;
.main-page__item > .main-page__label {
padding-left: 10px;
box-sizing: border-box;
font-size: 18px;
width: 226px;
}
li > input[type="text"] {
width: 226px
.main-page__item > .main-page__input {
width: 226px;
}
button.delete img {
height: 2em;
transform: rotateZ(45deg);
transition: transform 200ms ease-in;
.main-page__delete img {
height: 2em;
transform: rotateZ(45deg);
transition: transform 200ms ease-in;
}
button.delete img:hover {
transform: rotateZ(0);
.main-page__delete img:hover {
transform: rotateZ(0);
}

/* Completed */
ul#completed-tasks label {
text-decoration: line-through
color: #888;
.main-page__list-complete .main-page__label {
text-decoration: line-through;
color: #888;
}

/* Edit Task */
ul li input[type=text] {
display:none
.main-page__input {
display: none;
}

ul li.editMode input[type=text] {
display:inline-block;
width:224px
.main-page__edit-task .main-page__input {
display: inline-block;
width: 224px;
}

ul li.editMode label {
display:none;
.main-page__edit-task .main-page__label {
display: none;
}