Skip to content

Clean code #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Clean code #146

wants to merge 4 commits into from

Conversation

@SatiYeghoyan
Copy link

@SatiYeghoyan SatiYeghoyan commented Feb 19, 2025

@SatiYeghoyan
fix: rename attributes across HTML, CSS, and JS according to rule X.X…
19f9888 
… in html-and-css.md refactor: apply IDE refactoring tools for better code structure according to rule Y.Y in js-best-practices.md
@SatiYeghoyan
refactor: clean code
f042295
@SatiYeghoyan
fix: Marking as completed (toggleComplete),
21984d1 
-  The deleteTask function is already handling task deletion, whether it's in the todoList or completedList
-The editTask function works for both TODO and Competed task
@SatiYeghoyan
fix: use two spaces for indentation according to rule 1.1 in beginner…
c2caf48 
…-guidelines.md

refactor: rename attributes across HTML, CSS, and JS for consistency
- Renamed all IDs and class names in HTML to follow a structured convention
- Updated CSS selectors to match new naming
- Refactored JavaScript variables and function names accordingly
- Ensured all event listeners and DOM manipulations work correctly after renaming

style: improve code formatting and readability
- Used `const` and `let` instead of `var` in JavaScript
- Applied consistent indentation and spacing across all files
- Improved HTML structure with proper nesting
- Optimized CSS rules for better readability

feat: optimize addTask function and improve performance
- Prevented creation of empty tasks
- Used `Array.from()` for iterating instead of `for` loops
- Removed redundant DOM manipulations

fix: simplify and optimize task editing logic
- Improved `editTask` function with cleaner toggle logic
- Ensured correct text updates and button state switching
- Maintained proper task state handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@SatiYeghoyan