Clean code

app.js

@@ -1,195 +1,167 @@
-//Document is the DOM can be accessed in the console with document.window.
-// Tree is from the top, html, body, p etc.
-
-//Problem: User interaction does not provide the correct results.
-//Solution: Add interactivity so the user can manage daily tasks.
-//Break things down into smaller steps and take each step at a time.
-
-
-// Event handling, user interaction is what starts the code execution.
-
-var taskInput=document.getElementById("new-task");//Add a new task.
-var addButton=document.getElementsByTagName("button")[0];//first button
-var incompleteTaskHolder=document.getElementById("incompleteTasks");//ul of #incompleteTasks
-var completedTasksHolder=document.getElementById("completed-tasks");//completed-tasks
-
-
-//New task list item
-var createNewTaskElement=function(taskString){
-
-    var listItem=document.createElement("li");
-
-    //input (checkbox)
-    var checkBox=document.createElement("input");//checkbx
-    //label
-    var label=document.createElement("label");//label
-    //input (text)
-    var editInput=document.createElement("input");//text
-    //button.edit
-    var editButton=document.createElement("button");//edit button
-
-    //button.delete
-    var deleteButton=document.createElement("button");//delete button
-    var deleteButtonImg=document.createElement("img");//delete button image
-
-    label.innerText=taskString;
-    label.className='task';
-
-    //Each elements, needs appending
-    checkBox.type="checkbox";
-    editInput.type="text";
-    editInput.className="task";
-
-    editButton.innerText="Edit"; //innerText encodes special characters, HTML does not.
-    editButton.className="edit";
-
-    deleteButton.className="delete";
-    deleteButtonImg.src='./remove.svg';
-    deleteButton.appendChild(deleteButtonImg);
-
-
-    //and appending.
-    listItem.appendChild(checkBox);
-    listItem.appendChild(label);
-    listItem.appendChild(editInput);
-    listItem.appendChild(editButton);
-    listItem.appendChild(deleteButton);
-    return listItem;
+// ---------------------------
+// Get necessary DOM elements
+// ---------------------------
+const taskInput = document.getElementById("new-task");
+// In your HTML, the add button has class "todo-app__add-button"
+const addButton = document.querySelector(".todo-app__add-button");
+// ID in the HTML: "incomplete-tasks"
+const incompleteTaskHolder = document.getElementById("incomplete-tasks");
+// ID in the HTML: "completed-tasks"
+const completedTasksHolder = document.getElementById("completed-tasks");
+
+// -------------------------------------------------------
+// Function to create a new task list item (<li> element)
+// -------------------------------------------------------
+function createNewTaskElement(taskText) {
+  // Create a new <li> element with the "todo-app__item" class
+  const listItem = document.createElement("li");
+  listItem.className = "todo-app__item";
+
+  // Create a checkbox (type="checkbox") with "todo-app__checkbox" class
+  const checkBox = document.createElement("input");
+  checkBox.type = "checkbox";
+  checkBox.className = "todo-app__checkbox";
+
+  // Create a <label> with the text content and "todo-app__label" class
+  const label = document.createElement("label");
+  label.innerText = taskText;
+  label.className = "todo-app__label";
+
+  // Create an <input> for editing (type="text") with "todo-app__text-input" class
+  const editInput = document.createElement("input");
+  editInput.type = "text";
+  editInput.className = "todo-app__text-input";
+
+  // Create an Edit button with "todo-app__edit-button" class
+  const editButton = document.createElement("button");
+  editButton.innerText = "Edit";
+  editButton.className = "todo-app__edit-button";
+
+  // Create a Delete button with "todo-app__delete-button" class
+  const deleteButton = document.createElement("button");
+  deleteButton.className = "todo-app__delete-button";
+
+  // Add an <img> to the delete button
+  const deleteButtonImg = document.createElement("img");
+  deleteButtonImg.src = "./remove.svg";
+  deleteButtonImg.alt = "Remove";
+  deleteButton.appendChild(deleteButtonImg);
+
+  // Append all created elements into the <li>
+  listItem.appendChild(checkBox);
+  listItem.appendChild(label);
+  listItem.appendChild(editInput);
+  listItem.appendChild(editButton);
+  listItem.appendChild(deleteButton);
+
+  return listItem;
 }
 
+// -----------------------------
+// Function to add a new task
+// -----------------------------
+function addTask() {
+  // Prevent adding an empty string
+  if (!taskInput.value) return;
 
+  // Create the new <li> element
+  const listItem = createNewTaskElement(taskInput.value);
 
-var addTask=function(){
-    console.log("Add Task...");
-    //Create a new list item with the text from the #new-task:
-    if (!taskInput.value) return;
-    var listItem=createNewTaskElement(taskInput.value);
-
-    //Append listItem to incompleteTaskHolder
-    incompleteTaskHolder.appendChild(listItem);
-    bindTaskEvents(listItem, taskCompleted);
-
-    taskInput.value="";
-
-}
-
-//Edit an existing task.
-
-var editTask=function(){
-    console.log("Edit Task...");
-    console.log("Change 'edit' to 'save'");
-
-
-    var listItem=this.parentNode;
+  // Append the new task to the "incomplete tasks" list
+  incompleteTaskHolder.appendChild(listItem);
 
-    var editInput=listItem.querySelector('input[type=text]');
-    var label=listItem.querySelector("label");
-    var editBtn=listItem.querySelector(".edit");
-    var containsClass=listItem.classList.contains("editMode");
-    //If class of the parent is .editmode
-    if(containsClass){
-
-        //switch to .editmode
-        //label becomes the inputs value.
-        label.innerText=editInput.value;
-        editBtn.innerText="Edit";
-    }else{
-        editInput.value=label.innerText;
-        editBtn.innerText="Save";
-    }
-
-    //toggle .editmode on the parent.
-    listItem.classList.toggle("editMode");
-};
-
-
-//Delete task.
-var deleteTask=function(){
-    console.log("Delete Task...");
-
-    var listItem=this.parentNode;
-    var ul=listItem.parentNode;
-    //Remove the parent list item from the ul.
-    ul.removeChild(listItem);
+  // Bind event handlers (e.g., edit, delete, checkbox)
+  bindTaskEvents(listItem, markTaskCompleted);
 
+  // Clear the input field
+  taskInput.value = "";
 }
 
-
-//Mark task completed
-var taskCompleted=function(){
-    console.log("Complete Task...");
-
-    //Append the task list item to the #completed-tasks
-    var listItem=this.parentNode;
-    completedTasksHolder.appendChild(listItem);
-    bindTaskEvents(listItem, taskIncomplete);
-
+// -----------------------------
+// Function to edit a task
+// -----------------------------
+function editTask() {
+  const listItem = this.parentNode;
+  const editInput = listItem.querySelector('input[type="text"]');
+  const label = listItem.querySelector("label");
+  const editBtn = this;
+
+  // Check if <li> currently has the "todo-app__item--edit-mode" class
+  const isInEditMode = listItem.classList.contains("todo-app__item--edit-mode");
+
+  if (isInEditMode) {
+    // If already in edit mode, save the input value into the label
+    label.innerText = editInput.value;
+    editBtn.innerText = "Edit";
+  } else {
+    // If not in edit mode, switch to edit mode and populate input with label text
+    editInput.value = label.innerText;
+    editBtn.innerText = "Save";
+  }
+
+  // Toggle the edit mode class
+  listItem.classList.toggle("todo-app__item--edit-mode");
 }
 
-
-var taskIncomplete=function(){
-    console.log("Incomplete Task...");
-//Mark task as incomplete.
-    //When the checkbox is unchecked
-    //Append the task list item to the #incompleteTasks.
-    var listItem=this.parentNode;
-    incompleteTaskHolder.appendChild(listItem);
-    bindTaskEvents(listItem,taskCompleted);
+// -----------------------------
+// Function to delete a task
+// -----------------------------
+function deleteTask() {
+  const listItem = this.parentNode;
+  const ul = listItem.parentNode;
+  ul.removeChild(listItem);
 }
 
+// ------------------------------------------------------
+// Function to mark a task as completed (checkbox checked)
+// ------------------------------------------------------
+function markTaskCompleted() {
+  const listItem = this.parentNode;
+  // Move the task <li> to the completed tasks list
+  completedTasksHolder.appendChild(listItem);
 
-
-var ajaxRequest=function(){
-    console.log("AJAX Request");
+  // Re-bind events to handle "markTaskIncomplete" when checkbox is unchecked
+  bindTaskEvents(listItem, markTaskIncomplete);
 }
 
-//The glue to hold it all together.
-
-
-//Set the click handler to the addTask function.
-addButton.onclick=addTask;
-addButton.addEventListener("click",addTask);
-addButton.addEventListener("click",ajaxRequest);
+// ---------------------------------------------------------
+// Function to mark a task as incomplete (checkbox unchecked)
+// ---------------------------------------------------------
+function markTaskIncomplete() {
+  const listItem = this.parentNode;
+  // Move the task <li> back to the "Todo" list
+  incompleteTaskHolder.appendChild(listItem);
 
-
-var bindTaskEvents=function(taskListItem,checkBoxEventHandler){
-    console.log("bind list item events");
-//select ListItems children
-    var checkBox=taskListItem.querySelector("input[type=checkbox]");
-    var editButton=taskListItem.querySelector("button.edit");
-    var deleteButton=taskListItem.querySelector("button.delete");
-
-
-    //Bind editTask to edit button.
-    editButton.onclick=editTask;
-    //Bind deleteTask to delete button.
-    deleteButton.onclick=deleteTask;
-    //Bind taskCompleted to checkBoxEventHandler.
-    checkBox.onchange=checkBoxEventHandler;
+  // Re-bind events to handle "markTaskCompleted" when checkbox is checked
+  bindTaskEvents(listItem, markTaskCompleted);
 }
 
-//cycle over incompleteTaskHolder ul list items
-//for each list item
-for (var i=0; i<incompleteTaskHolder.children.length;i++){
-
-    //bind events to list items chldren(tasksCompleted)
-    bindTaskEvents(incompleteTaskHolder.children[i],taskCompleted);
+// -------------------------------------------------
+// Function to bind all event handlers for one <li>
+// -------------------------------------------------
+function bindTaskEvents(taskListItem, checkBoxHandler) {
+  const checkBox = taskListItem.querySelector('input[type="checkbox"]');
+  const editButton = taskListItem.querySelector(".todo-app__edit-button");
+  const deleteButton = taskListItem.querySelector(".todo-app__delete-button");
+
+  editButton.onclick = editTask;
+  deleteButton.onclick = deleteTask;
+  checkBox.onchange = checkBoxHandler;
 }
 
+// -----------------------------
+// Initial code execution
+// -----------------------------
 
+// Add task when the "Add" button is clicked
+addButton.addEventListener("click", addTask);
 
-
-//cycle over completedTasksHolder ul list items
-for (var i=0; i<completedTasksHolder.children.length;i++){
-    //bind events to list items chldren(tasksIncompleted)
-    bindTaskEvents(completedTasksHolder.children[i],taskIncomplete);
+// Bind existing items in the "incomplete tasks" list
+for (let i = 0; i < incompleteTaskHolder.children.length; i++) {
+  bindTaskEvents(incompleteTaskHolder.children[i], markTaskCompleted);
 }
 
-
-
-
-// Issues with usability don't get seen until they are in front of a human tester.
-
-//prevent creation of empty tasks.
-
-//Change edit to save when you are in edit mode.
+// Bind existing items in the "completed tasks" list
+for (let j = 0; j < completedTasksHolder.children.length; j++) {
+  bindTaskEvents(completedTasksHolder.children[j], markTaskIncomplete);
+}