Skip to content

Conversation

@stepbrobd
Copy link

@stepbrobd
Copy link
Author

stepbrobd commented Sep 19, 2025

in the newly pinned nixpkgs source, i added a line to unconditionally throw when we hit the builtins.fetchTarball branch

@proux01 cc @vbgl i will get this one ready once the deprecation PR hits nixpkgs master, but this proof of concept seem to work just fine

@proux01
Copy link
Collaborator

proux01 commented Sep 22, 2025

@stepbrobd that crude solution won't work, it's not just about the master branch of Rocq here, the feature is used all over the place in all CIs to test PR branches and overlays, having to do this everywhere would be a serious regression, we need something better here (i.e., inside the toolbox) that doesn't require an heavy update in every CI config

@stepbrobd
Copy link
Author

np, i'll add a better implementation in the coming days.

in the new implementation, i plan to check if a package's given version is in release (e.g. https://github.com/NixOS/nixpkgs/blob/nixos-25.05/pkgs/development/coq-modules/gaia/default.nix#L13, though release is not publicly exposed yet), and move the eval time fetcher in-tree as fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants