feat: Support dynamic selectors in dataset upload registration tags #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable STRING_KIND selectors within arrays while maintaining restrictions on LIST_OF_VALUES_KIND selectors in mixed arrays. This solves the customer issue where `["literal", "$inputs.tag"]` was not supported in Dataset Upload block registration_tags. Key changes: - Modified schema parser to allow first-level array selectors - Added validation to prevent invalid mixed array patterns - Created comprehensive test coverage for both components - Improved error messaging for better developer experience Fixes array selector restrictions while maintaining safety for complex nesting patterns.
Grantimus9
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
hansent,
probicheaux and
yeldarby
as code owners
…on-dataset-upload-block
Collaborator
|
It does not seem to work 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables support for dynamic selectors in array inputs, specifically addressing the customer issue where
["literal", "$inputs.tag"]patterns were not supported in Dataset Upload block registration_tags.The implementation allows STRING_KIND selectors within arrays while maintaining safety restrictions on LIST_OF_VALUES_KIND selectors in mixed arrays.
Key Changes
schema_parser.py:367-371to allow first-level array selectors while maintaining deeper nesting restrictionsstep_input_assembler.pyto detect and prevent invalid mixed array patternsProblem Solved
Before: Arrays with selectors like
["literal", "$inputs.tag"]were completely ignored by the schema parserAfter: These patterns now work correctly with proper
any_datareferences and validationValidation Logic
✅ Allowed Patterns:
["literal1", "literal2", "$inputs.string_tag"]- Mixed arrays with STRING_KIND selectors"$inputs.list_tags"- Pure LIST_OF_VALUES_KIND selectors["$inputs.tag1", "$inputs.tag2"]- Multiple STRING_KIND selectors❌ Prevented Patterns:
["literal", "$inputs.list_tags"]- Mixed arrays with LIST_OF_VALUES_KIND selectors (clear error message)List[List[Selector]]- Deep nesting (existing restriction maintained)Test Results
All unit tests verify the implementation works correctly and prevent regressions.
Backward Compatibility
This change is fully backward compatible - existing workflows continue to work unchanged while new dynamic selector patterns are now supported.