Skip to content

⚡️ Speed up function serialise_image by 679% in PR #1672 (bruno/parent-metadata-serialization) #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −4
Open

⚡️ Speed up function serialise_image by 679% in PR #1672 (bruno/parent-metadata-serialization) #1673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions inference/core/workflows/core_steps/common/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,14 +292,14 @@ def serialise_image(image: WorkflowImageData) -> Dict[str, Any]:
# Add parent origin metadata if image is a crop/slice
if parent_metadata.parent_id != root_metadata.parent_id:
result[PARENT_ID_KEY] = parent_metadata.parent_id
result[PARENT_ORIGIN_KEY] = ParentOrigin.from_origin_coordinates_system(
result[PARENT_ORIGIN_KEY] = _parent_origin_as_dict(
parent_metadata.origin_coordinates
).model_dump()
)

result[ROOT_PARENT_ID_KEY] = root_metadata.parent_id
result[ROOT_PARENT_ORIGIN_KEY] = ParentOrigin.from_origin_coordinates_system(
result[ROOT_PARENT_ORIGIN_KEY] = _parent_origin_as_dict(
root_metadata.origin_coordinates
).model_dump()
)

return result

Expand Down Expand Up @@ -349,3 +349,12 @@ def serialize_secret(secret: str) -> str:

def serialize_timestamp(timestamp: datetime) -> str:
return timestamp.isoformat()


def _parent_origin_as_dict(origin_coordinates_system) -> dict:
return {
"offset_x": origin_coordinates_system.left_top_x,
"offset_y": origin_coordinates_system.left_top_y,
"width": origin_coordinates_system.origin_width,
"height": origin_coordinates_system.origin_height,
}