[Draft] Fix free cache engine weight sync #298
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tentative fix to the issue #291: where the weight sync between rollout engine and trainer engine is completely missing (an obvious issue that
verlalso hasn't fixed yet) when configactor_rollout_ref.rollout.free_cache_engine=False.Fortunately this seems fixable without patching
verlas inrLLMwe implement our own rollout trajectory generation logic. In fact, therollout_engine.wake_up()/sleep()method should be run regardless of thefree_cache_engineflag -- the flag will be checked again anyway during thewake_up/sleepcall anyway. For instance, the release ofkv-cachein the inference engine will do an extra check here.This PR should not affect the usual case when
free_cache_engine = Trueat all. Some experiments are on-going to see if there is any side-effect whenfree_cache_engine = False(so this PR is still under draft)