Skip to content
This repository was archived by the owner on Oct 22, 2025. It is now read-only.

Conversation

@NathanFlurry
Copy link
Member

No description provided.

Copy link
Member Author

NathanFlurry commented Jun 25, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

serve({ fetch: app.fetch, port: 8080 }, (x) =>
console.log("Listening at http://localhost:8080"),
);
injectWebSocket(server)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The server variable is undefined at this point. The serve function call on lines 67-69 doesn't assign its return value to a variable, so injectWebSocket(server) will throw a ReferenceError. Consider capturing the return value from serve first:

const server = serve({ fetch: app.fetch, port: 8080 }, (x) =>
  console.log("Listening at http://localhost:8080"),
);
injectWebSocket(server);
Suggested change
injectWebSocket(server)
const server = serve({ fetch: app.fetch, port: 8080 }, (x) =>
console.log("Listening at http://localhost:8080"),
);
injectWebSocket(server);

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@NathanFlurry NathanFlurry force-pushed the 06-24-chore_add_rivet_as_a_default_driver branch from 0419102 to e7a3580 Compare June 25, 2025 00:11
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 25, 2025

Open in StackBlitz

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/core@1004

rivetkit

pnpm add https://pkg.pr.new/rivet-gg/rivetkit@1004

@rivetkit/worker

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/worker@1004

@rivetkit/file-system

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/file-system@1004

@rivetkit/redis

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/redis@1004

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/framework-base@1004

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/react@1004

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/cloudflare-workers@1004

commit: 69062e3

@NathanFlurry NathanFlurry force-pushed the 06-24-chore_add_rivet_as_a_default_driver branch 7 times, most recently from 80ed0ab to 38d8fca Compare June 25, 2025 19:18
@jog1t jog1t force-pushed the 06-24-chore_add_rivet_as_a_default_driver branch from 69062e3 to f18a638 Compare June 26, 2025 19:27
@jog1t jog1t force-pushed the 06-24-chore_rename_rivetkit_-_rivetkit_core_expose_rivetkit_worker branch from 06f601c to 5af6174 Compare June 26, 2025 19:27
@jog1t jog1t mentioned this pull request Jun 26, 2025
@NathanFlurry NathanFlurry force-pushed the 06-24-chore_add_rivet_as_a_default_driver branch from f18a638 to 69062e3 Compare June 27, 2025 08:43
@NathanFlurry NathanFlurry force-pushed the 06-24-chore_rename_rivetkit_-_rivetkit_core_expose_rivetkit_worker branch from 5af6174 to 06f601c Compare June 27, 2025 08:43
@graphite-app
Copy link

graphite-app bot commented Jun 27, 2025

Merge activity

  • Jun 27, 8:53 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Jun 27, 8:55 AM UTC: CI is running for this pull request on a draft pull request (#1030) due to your merge queue CI optimization settings.
  • Jun 27, 8:56 AM UTC: Merged by the Graphite merge queue via draft PR: #1030.

graphite-app bot pushed a commit that referenced this pull request Jun 27, 2025
@graphite-app graphite-app bot closed this Jun 27, 2025
@graphite-app graphite-app bot deleted the 06-24-chore_add_rivet_as_a_default_driver branch June 27, 2025 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants