This repository was archived by the owner on Oct 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
chore: add rivet as a default driver #1004
Closed
NathanFlurry
wants to merge
1
commit into
06-24-chore_rename_rivetkit_-_rivetkit_core_expose_rivetkit_worker
from
06-24-chore_add_rivet_as_a_default_driver
Closed
chore: add rivet as a default driver #1004
NathanFlurry
wants to merge
1
commit into
06-24-chore_rename_rivetkit_-_rivetkit_core_expose_rivetkit_worker
from
06-24-chore_add_rivet_as_a_default_driver
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
1821ffc to
0419102
Compare
| serve({ fetch: app.fetch, port: 8080 }, (x) => | ||
| console.log("Listening at http://localhost:8080"), | ||
| ); | ||
| injectWebSocket(server) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The server variable is undefined at this point. The serve function call on lines 67-69 doesn't assign its return value to a variable, so injectWebSocket(server) will throw a ReferenceError. Consider capturing the return value from serve first:
const server = serve({ fetch: app.fetch, port: 8080 }, (x) =>
console.log("Listening at http://localhost:8080"),
);
injectWebSocket(server);
Suggested change
| injectWebSocket(server) | |
| const server = serve({ fetch: app.fetch, port: 8080 }, (x) => | |
| console.log("Listening at http://localhost:8080"), | |
| ); | |
| injectWebSocket(server); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
0419102 to
e7a3580
Compare
@rivetkit/core
rivetkit
@rivetkit/worker
@rivetkit/file-system
@rivetkit/redis
@rivetkit/framework-base
@rivetkit/react
@rivetkit/cloudflare-workers
commit: |
80ed0ab to
38d8fca
Compare
38d8fca to
69062e3
Compare
This was referenced Jun 25, 2025
Closed
Closed
This was referenced Jun 26, 2025
69062e3 to
f18a638
Compare
06f601c to
5af6174
Compare
Draft
f18a638 to
69062e3
Compare
5af6174 to
06f601c
Compare
This was referenced Jun 27, 2025
Closed
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

No description provided.