-
Notifications
You must be signed in to change notification settings - Fork 130
chore(rivetkit): remove deprecated conn tokens & sse support #3419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(rivetkit): remove deprecated conn tokens & sse support #3419
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
PR Review: Remove deprecated conn tokens & SSE supportSummaryThis PR removes deprecated connection token authentication and SSE (Server-Sent Events) support from RivetKit, streamlining the connection protocol. The changes include protocol versioning updates and a migration path for persisted actor state. Code Quality ✅Strengths:
Areas for attention:
Potential Bugs 🐛
Security Concerns 🔒
Performance Considerations ⚡
Test Coverage 🧪Changes to test files:
Recommendations:
Breaking Changes 🔴This PR introduces breaking changes:
Migration path: The protocol versioning should handle older clients, but verify all client SDKs are updated. Action Items 📋Critical:
Recommended:
Overall AssessmentThis is a well-intentioned cleanup that simplifies the codebase, but has one critical bug (subscription loss) that needs to be fixed before merging. The schema versioning and migration approach is solid, but needs additional test coverage. Recommendation: Request changes to fix the subscription persistence issue, then approve after verification. |
More templates
@rivetkit/actor
@rivetkit/cloudflare-workers
@rivetkit/core
@rivetkit/db
@rivetkit/framework-base
@rivetkit/next-js
@rivetkit/react
rivetkit
@rivetkit/sql-loader
@rivetkit/engine-runner
@rivetkit/engine-runner-protocol
commit: |

No description provided.