-bin-annot by default, -bs-no-bin-annot for power users

Author: bobzhang

docs/docson/build-schema.json

@@ -177,15 +177,15 @@
         },
         "ppx-flags": {
             "$ref": "#/definitions/ppx-specs",
-            "description": "TODO: ppx flags"
+            "description": "syntax is package_name/binary, for example: reason/reactjs_jsx_ppx.native"
         },
         "bsc-flags": {
             "$ref": "#/definitions/stringArray",
             "description": "A list of flags for bsc.exe"
         },
         "package-specs": {
             "$ref": "#/definitions/package-specs",
-            "description": "TODO: currently only support commonjs"
+            "description": "currently support commonjs, amdjs and google module"
         },
         "ocamllex": {
             "type": "string",
@@ -201,22 +201,24 @@
         },
         "refmt": {
             "type": "string",
-            "description": "Path to refmt"
+            "description": "Path to refmt for Reason syntax, for example: reason/refmt_impl.native"
         },
         "bs-external-includes": {
             "$ref": "#/definitions/stringArray",
-            "description": "external include directories, which will be applied -I to all compilation units, it is not needed in most cases"
+            "description": "external include directories, which will be applied -I to all compilation units, it is *not needed* in most cases"
         },
         "sources": {
             "oneOf": [
                 {
                     "type": "array",
                     "items": {
                         "$ref": "#/definitions/sourceItem"
-                    }
+                    },
+                    "description" : "A list of source items"
                 },
                 {
-                    "$ref": "#/definitions/sourceItem"
+                    "$ref": "#/definitions/sourceItem",
+                    "description": "A single source item"
                 }
             ]
         },

jscomp/Makefile

@@ -251,8 +251,10 @@ OTHER_CORE_SRCS= bsppx_main bspack_main jsoo_main  bspp_main js_cmi_datasets \
 		 js_main
 OTHER_CORE_CMXS= $(addprefix core/, $(addsuffix .cmx, $(OTHER_CORE_SRCS)))
 BSB_SRCS= bsb_config bsb_build_schemas bsb_build_util \
-	bsb_dep_infos bsb_dir bsb_ninja \
-	bsb_build_ui bsb_default bsb_gen\
+	bsb_dir bsb_ninja \
+	bsb_build_ui bsb_default\
+	bsb_dep_infos\
+	 bsb_gen\
 	bsb_unix
 
 BSB_CMXS=$(addprefix bsb/, $(addsuffix .cmx, $(BSB_SRCS)))

jscomp/bin/whole_compiler.ml

@@ -105780,6 +105780,9 @@ let buckle_script_flags =
    " only check syntax"
   )
   ::
+  ("-bs-no-bin-annot", Arg.Clear Clflags.binary_annotations, 
+   " disable binary annotations (by default on)")
+  ::
   ("-bs-eval", 
    Arg.String set_eval_string, 
    " (experimental) Set the string to be evaluated, note this flag will be conflicted with -bs-main"
@@ -105883,6 +105886,7 @@ let buckle_script_flags =
 let _ = 
   Clflags.unsafe_string := false;
   Clflags.debug := true;
+  Clflags.binary_annotations := true; 
   Bs_conditional_initial.setup_env ();
   try
     Compenv.readenv ppf Before_args;

jscomp/core/js_main.ml

@@ -155,6 +155,9 @@ let buckle_script_flags =
    " only check syntax"
   )
   ::
+  ("-bs-no-bin-annot", Arg.Clear Clflags.binary_annotations, 
+   " disable binary annotations (by default on)")
+  ::
   ("-bs-eval", 
    Arg.String set_eval_string, 
    " (experimental) Set the string to be evaluated, note this flag will be conflicted with -bs-main"
@@ -258,6 +261,7 @@ let buckle_script_flags =
 let _ = 
   Clflags.unsafe_string := false;
   Clflags.debug := true;
+  Clflags.binary_annotations := true; 
   Bs_conditional_initial.setup_env ();
   try
     Compenv.readenv ppf Before_args;