Merge pull request #1110 from bloomberg/sort_by_default

convinced sort by default is better, adding -bs-no-sort-imports for power users

Author: bobzhang

jscomp/bin/bsb.ml

@@ -2668,7 +2668,7 @@ let set_no_any_assert () = no_any_assert := true
 let get_no_any_assert () = !no_any_assert
 
 let better_errors = ref false
-let sort_imports = ref false
+let sort_imports = ref true
 let dump_js = ref false
 
 let is_windows =

jscomp/bin/bsdep.ml

@@ -24927,7 +24927,7 @@ let set_no_any_assert () = no_any_assert := true
 let get_no_any_assert () = !no_any_assert
 
 let better_errors = ref false
-let sort_imports = ref false
+let sort_imports = ref true
 let dump_js = ref false
 
 let is_windows =

jscomp/bin/bsppx.ml

@@ -6774,7 +6774,7 @@ let set_no_any_assert () = no_any_assert := true
 let get_no_any_assert () = !no_any_assert
 
 let better_errors = ref false
-let sort_imports = ref false
+let sort_imports = ref true
 let dump_js = ref false
 
 let is_windows =

jscomp/bin/whole_compiler.ml

@@ -22316,7 +22316,7 @@ let set_no_any_assert () = no_any_assert := true
 let get_no_any_assert () = !no_any_assert
 
 let better_errors = ref false
-let sort_imports = ref false
+let sort_imports = ref true
 let dump_js = ref false
 
 let is_windows =
@@ -105788,7 +105788,12 @@ let buckle_script_flags =
   (
     "-bs-sort-imports",
     Arg.Set Js_config.sort_imports,
-    " Sort the imports by lexical order so the output will be more stable"
+    " Sort the imports by lexical order so the output will be more stable (default false)"
+  )
+  ::
+  ( "-bs-no-sort-imports", 
+    Arg.Clear Js_config.sort_imports,
+    " No sort (see -bs-sort-imports)"
   )
   ::
   ("-bs-better-errors",

jscomp/common/js_config.ml

@@ -215,7 +215,7 @@ let set_no_any_assert () = no_any_assert := true
 let get_no_any_assert () = !no_any_assert
 
 let better_errors = ref false
-let sort_imports = ref false
+let sort_imports = ref true
 let dump_js = ref false
 
 let is_windows =

jscomp/core/js_main.ml

@@ -163,7 +163,12 @@ let buckle_script_flags =
   (
     "-bs-sort-imports",
     Arg.Set Js_config.sort_imports,
-    " Sort the imports by lexical order so the output will be more stable"
+    " Sort the imports by lexical order so the output will be more stable (default false)"
+  )
+  ::
+  ( "-bs-no-sort-imports", 
+    Arg.Clear Js_config.sort_imports,
+    " No sort (see -bs-sort-imports)"
   )
   ::
   ("-bs-better-errors",

jscomp/test/a_filename_test.js

@@ -1,9 +1,9 @@
 'use strict';
 
-var Block        = require("../../lib/js/block");
+var Mt           = require("./mt");
 var $$Array      = require("../../lib/js/array");
+var Block        = require("../../lib/js/block");
 var Ext_filename = require("./ext_filename");
-var Mt           = require("./mt");
 
 var suites = [/* [] */0];
 

jscomp/test/a_list_test.js

@@ -1,8 +1,8 @@
 'use strict';
 
+var Mt       = require("./mt");
 var Block    = require("../../lib/js/block");
 var Ext_list = require("./ext_list");
-var Mt       = require("./mt");
 
 var suites_000 = /* tuple */[
   "drop",

jscomp/test/a_string_test.js

@@ -1,9 +1,9 @@
 'use strict';
 
-var Block      = require("../../lib/js/block");
-var Ext_string = require("./ext_string");
 var Mt         = require("./mt");
 var List       = require("../../lib/js/list");
+var Block      = require("../../lib/js/block");
+var Ext_string = require("./ext_string");
 
 var suites_000 = /* tuple */[
   "split",

jscomp/test/and_or_tailcall_test.js

@@ -1,7 +1,7 @@
 'use strict';
 
-var Block = require("../../lib/js/block");
 var Mt    = require("./mt");
+var Block = require("../../lib/js/block");
 
 function f(b, _, _n) {
   while(true) {