feat: Add Bitbucket Data Center support #227
Conversation
brushmate
force-pushed
the
bitbucket-data-center-support
branch
from
4bc6d7d to
92404d2
Compare
|
|
||
| env: | ||
| IMAGE_NAME: ghcr.io/renovatebot/renovate-approve-bot-bitbucket-cloud | ||
| IMAGE_NAME: ghcr.io/renovatebot/renovate-approve-bot-bitbucket |
There was a problem hiding this comment.
@maxbrunet @viceice do you have any concerns about this breaking change? Ideas on how to unbreak it for users, or alert them?
There was a problem hiding this comment.
we probably should publish both images for a while
There was a problem hiding this comment.
I wonder if we should bundle other breaking changes for v2?
- Upgrade to node v18 #166
- Migrate to ESM with upgrade to got v12 and jest v28
And the code getting larger, TypeScript (#58) starts making more sense
FYI I do not use Bitbucket anymore, so I will not be able to help testing this
viceice
left a comment
viceice
left a comment
There was a problem hiding this comment.
this PR should be split to multiple.
- repo rename
- code refactor
- server support
| LABEL \ | ||
| org.opencontainers.image.source="https://github.com/renovatebot/renovate-approve-bot-bitbucket-cloud" \ | ||
| org.opencontainers.image.url="https://github.com/renovatebot/renovate-approve-bot-bitbucket-cloud" \ | ||
| org.opencontainers.image.source="https://github.com/renovatebot/renovate-approve-bot-bitbucket" \ |
There was a problem hiding this comment.
repo rename should be a separate PR/ step with a major version bump.
should probably be done before this PR.
|
Alright, I will try to break up this pull request. If I understood correctly, the plan is to do this change amongst other things in version 2. Some questions came to my mind:
|
no, the repo rename can be done without a breaking change, we simply publish the old image additionally for a while and drop it on a later major bump.
Sure, but it needs somebody from community to do that. |
4 participants
As discussed in #214 this pull request adds support for Bitbucket Data Center and Server. Existing Bitbucket Cloud users need to update the Docker image name since I removed the
-cloudsuffix, but the bot will still connect to Bitbucket Cloud by default. Only if you set theBITBUCKET_URLenvironment variable, it will use the new Bitbucket Data Center specific code.