Implement priority sorting logic for LearnEth tutorials #6504
Conversation
✅ Deploy Preview for reliable-cocada-166884 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| }, | ||
| }, | ||
| effects: { | ||
| *loadRepo({ payload }, { put, select }) { |
There was a problem hiding this comment.
That’s right. This was written temporarily to use mock data, so please just check the priority logic. I’ll roll it back later.
There was a problem hiding this comment.
The update has been completed.
hsy822
force-pushed
the
ordering-tutorials-in-learneth
branch
from
0c026cb to
f717126
Compare
|
I've update the remix-workshops so that each .yml file has a priority key. So the dummy data can be removed here. |
|
I am not sure its in the scope of this PR, but in the description of each tutorial, the title of the tutorial is prefixing the description and it should be removed. See: |
hsy822
force-pushed
the
ordering-tutorials-in-learneth
branch
from
f717126 to
e32b85f
Compare
@ryestew The description was originally read from the README file, but it has been changed to be fetched from the summary field in the .yml file. |
fixes #6501
This PR implements the new sorting logic for LearnEth tutorials as requested and sets the filter panel to be open by default.
Key Changes
Home/index.tsx):Level(asc)priority(asc, lower numbers first)name(alphabetical)priorityare sorted last, alphabetically by name.Home/index.tsx):showFilterstotrue.workshop.ts):.ymlfiles are not yet updated with thepriorityfield, I have added mock data inworkshop.tsto allow for immediate testing.loadRepofunction is commented out, and a temporaryloadRepois used to inject this mock data..ymlfiles are updated and deployed,workshop.tscan be easily reverted (uncomment original function, delete mock data).@ryestew Please review the new sorting logic and the default filter state.