Skip to content

Fix: Replace MD5 with SHA256 for FIPS compliance #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Replace MD5 with SHA256 for FIPS compliance #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions lib/eslint-formatter-codeclimate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,24 @@ import { relative } from 'node:path'
* The fingerprint for the ESLint report message.
*/
function createFingerprint(filePath, message, hashes) {
const md5 = createHash('md5')
md5.update(filePath)
const sha256 = createHash('sha256')
sha256.update(filePath)
if (message.ruleId) {
md5.update(message.ruleId)
sha256.update(message.ruleId)
}
md5.update(message.message)
sha256.update(message.message)

// Create copy of hash since md5.digest() will finalize it, not allowing us to .update() again
let md5Tmp = md5.copy()
let hash = md5Tmp.digest('hex')
// Create copy of hash since sha256.digest() will finalize it, not allowing us to .update() again
let sha256Tmp = sha256.copy()
let hash = sha256Tmp.digest('hex')

while (hashes.has(hash)) {
// Hash collision. This happens if we encounter the same ESLint message in one file
// multiple times. Keep generating new hashes until we get a unique one.
md5.update(hash)
sha256.update(hash)

md5Tmp = md5.copy()
hash = md5Tmp.digest('hex')
sha256Tmp = sha256.copy()
hash = sha256Tmp.digest('hex')
}

hashes.add(hash)
Expand Down
34 changes: 17 additions & 17 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ describe('toCodeClimate', () => {
categories: ['Style'],
check_name: '',
description: 'Parsing error: Unexpected token',
fingerprint: 'cbf6619c6f5a4b997a6c4b9eab150ad2',
fingerprint: '3d67384197ac8bfd7dcb9d4d81eab675ecd459ed8bae5ec4e681a1bceef48788',
location: {
positions: { begin: { line: 2, column: 1 }, end: { line: 2, column: 1 } },
path: 'fatal.js'
Expand All @@ -37,7 +37,7 @@ describe('toCodeClimate', () => {
body: 'Disallow the use of `debugger`\n\n[no-debugger](https://eslint.org/docs/latest/rules/no-debugger)'
},
description: "Unexpected 'debugger' statement.",
fingerprint: '3669b857c8f6f91c9abb11871eb81ad1',
fingerprint: 'daff1f5f24794988561d3c2df5e0242800e6a7d8874bffaf612ada36fe6490de',
location: {
positions: { begin: { line: 1, column: 1 }, end: { line: 1, column: 9 } },
path: 'fixture.js'
Expand All @@ -52,7 +52,7 @@ describe('toCodeClimate', () => {
body: 'Disallow the use of `console`\n\n[no-console](https://eslint.org/docs/latest/rules/no-console)'
},
description: 'Unexpected console statement.',
fingerprint: 'ad51b34553a9ef5712d8cf58956dc994',
fingerprint: 'd2ea3e82aa0f9fdfac7138e742d22645a7062163362d03358dcab94a1b71d8cf',
location: {
positions: { begin: { line: 2, column: 1 }, end: { line: 2, column: 12 } },
path: 'fixture.js'
Expand All @@ -74,7 +74,7 @@ describe('toCodeClimate', () => {
categories: ['Style'],
check_name: '',
description: 'Parsing error: Unexpected token',
fingerprint: 'cbf6619c6f5a4b997a6c4b9eab150ad2',
fingerprint: '3d67384197ac8bfd7dcb9d4d81eab675ecd459ed8bae5ec4e681a1bceef48788',
location: {
positions: { begin: { line: 2, column: 1 }, end: { line: 2, column: 1 } },
path: 'fatal.js'
Expand All @@ -89,7 +89,7 @@ describe('toCodeClimate', () => {
body: 'Disallow the use of `debugger`\n\n[no-debugger](https://eslint.org/docs/latest/rules/no-debugger)'
},
description: "Unexpected 'debugger' statement.",
fingerprint: '3669b857c8f6f91c9abb11871eb81ad1',
fingerprint: 'daff1f5f24794988561d3c2df5e0242800e6a7d8874bffaf612ada36fe6490de',
location: {
positions: { begin: { line: 1, column: 1 }, end: { line: 1, column: 9 } },
path: 'fixture.js'
Expand All @@ -104,7 +104,7 @@ describe('toCodeClimate', () => {
body: 'Disallow the use of `console`\n\n[no-console](https://eslint.org/docs/latest/rules/no-console)'
},
description: 'Unexpected console statement.',
fingerprint: 'ad51b34553a9ef5712d8cf58956dc994',
fingerprint: 'd2ea3e82aa0f9fdfac7138e742d22645a7062163362d03358dcab94a1b71d8cf',
location: {
positions: { begin: { line: 2, column: 1 }, end: { line: 2, column: 12 } },
path: 'fixture.js'
Expand All @@ -129,7 +129,7 @@ describe('toCodeClimate', () => {
body: 'Disallow the use of `debugger`\n\n[no-debugger](https://eslint.org/docs/latest/rules/no-debugger)'
},
description: "Unexpected 'debugger' statement.",
fingerprint: '3669b857c8f6f91c9abb11871eb81ad1',
fingerprint: 'daff1f5f24794988561d3c2df5e0242800e6a7d8874bffaf612ada36fe6490de',
location: {
positions: { begin: { line: 1, column: 1 }, end: { line: 1, column: 9 } },
path: 'fixture.js'
Expand All @@ -144,7 +144,7 @@ describe('toCodeClimate', () => {
body: 'Disallow the use of `debugger`\n\n[no-debugger](https://eslint.org/docs/latest/rules/no-debugger)'
},
description: "Unexpected 'debugger' statement.",
fingerprint: 'b5b0e1d51da3906f565fcbcfb5964346',
fingerprint: 'bdcd1dec9754c703ad4d607227ce800c7ff3848c224f73ab4aed81b1a150a472',
location: {
positions: { begin: { line: 1, column: 1 }, end: { line: 1, column: 9 } },
path: 'fixture.js'
Expand All @@ -167,7 +167,7 @@ describe('toCodeClimate', () => {
check_name: '',
description:
"Unused eslint-disable directive (no problems were reported from 'no-debugger').",
fingerprint: '0d88946a05ccd7175f2711bd7f8821ee',
fingerprint: 'a547cb8bca980b99e4c80050268b9423b9cc10277d6e84fbea47a1e421315287',
location: {
positions: { begin: { line: 1, column: 1 }, end: { line: 1, column: 1 } },
path: 'fixture.js'
Expand All @@ -189,7 +189,7 @@ describe('toCodeClimate', () => {
categories: ['Style'],
check_name: 'plugin/missing-meta',
description: 'Missing docs',
fingerprint: 'edf9d1d54d9c89dd1412ef11a7413b45',
fingerprint: '7db55200708454f50b03e92f4a1586c753f87b40f635997ee6b9a34b4aa76247',
location: {
positions: { begin: { line: 8, column: 1 }, end: { line: 75, column: 2 } },
path: 'eslint.config.js'
Expand All @@ -201,7 +201,7 @@ describe('toCodeClimate', () => {
categories: ['Style'],
check_name: 'plugin/empty-meta',
description: 'Missing docs',
fingerprint: 'c67e7c9c1a844b65d30710d9d9278d40',
fingerprint: '7315c2bbb5f1c3ae82f633c47780a91b5f5394dab9bb648fd6a5b06f7d2f6824',
location: {
positions: { begin: { line: 8, column: 1 }, end: { line: 75, column: 2 } },
path: 'eslint.config.js'
Expand All @@ -213,7 +213,7 @@ describe('toCodeClimate', () => {
categories: ['Style'],
check_name: 'plugin/empty-docs',
description: 'Empty docs',
fingerprint: '5ac7fe0fe3025663d064826d49e27164',
fingerprint: '6d435ef65c2398cf029a5081734a7677ee9a62aeb6701406a08eb2f8ee32d927',
location: {
positions: { begin: { line: 8, column: 1 }, end: { line: 75, column: 2 } },
path: 'eslint.config.js'
Expand All @@ -226,7 +226,7 @@ describe('toCodeClimate', () => {
check_name: 'plugin/no-description',
content: { body: '[plugin/no-description](https://example.com)' },
description: 'No description',
fingerprint: '256e5d936b053b630b4993f7dd8bedd6',
fingerprint: 'c98c3855c9d302774f717192d0e7c36a418850367164d3f6322d3ef267ae62a4',
location: {
positions: { begin: { line: 8, column: 1 }, end: { line: 75, column: 2 } },
path: 'eslint.config.js'
Expand All @@ -239,7 +239,7 @@ describe('toCodeClimate', () => {
check_name: 'plugin/no-url',
content: { body: 'Description only' },
description: 'No URL',
fingerprint: '5a89671407235a680cac73999a076960',
fingerprint: '65c7816ad5a8e04459afa119a7ecd98e64eef677fc1b4b5e27f1a28e52b59a73',
location: {
positions: { begin: { line: 8, column: 1 }, end: { line: 75, column: 2 } },
path: 'eslint.config.js'
Expand Down Expand Up @@ -269,7 +269,7 @@ describe('formatter', () => {
"check_name": "",
"description": "Parsing error: Unexpected token",
"severity": "critical",
"fingerprint": "cbf6619c6f5a4b997a6c4b9eab150ad2",
"fingerprint": "3d67384197ac8bfd7dcb9d4d81eab675ecd459ed8bae5ec4e681a1bceef48788",
"location": {
"path": "fatal.js",
"positions": {
Expand All @@ -293,7 +293,7 @@ describe('formatter', () => {
"check_name": "no-debugger",
"description": "Unexpected 'debugger' statement.",
"severity": "minor",
"fingerprint": "3669b857c8f6f91c9abb11871eb81ad1",
"fingerprint": "daff1f5f24794988561d3c2df5e0242800e6a7d8874bffaf612ada36fe6490de",
"location": {
"path": "fixture.js",
"positions": {
Expand All @@ -319,7 +319,7 @@ describe('formatter', () => {
"check_name": "no-console",
"description": "Unexpected console statement.",
"severity": "major",
"fingerprint": "ad51b34553a9ef5712d8cf58956dc994",
"fingerprint": "d2ea3e82aa0f9fdfac7138e742d22645a7062163362d03358dcab94a1b71d8cf",
"location": {
"path": "fixture.js",
"positions": {
Expand Down