Byte-shave various chunks of code #5129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7891846:
|
size-limit report 📦
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
Eh, messing with Confirmed using some Sonda analysis in an actual Vite app example that this knocks about 0.6K off the final app size. |
glepretre
reviewed
Nov 4, 2025
| false, | ||
| ) | ||
| window.addEventListener('focus', handleFocus, false) | ||
| const WINDOW = window |
There was a problem hiding this comment.
We lost the SSR support here in v2.10.0
UnhandledRejection ReferenceError: window is not defined
at defaultHandler (file:///node_modules/@reduxjs/toolkit/dist/query/rtk-query.modern.mjs:417:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR byte-shaves a variety of repeated bits of code I saw:
setupListenersto reuse event names and deduplicatewindow.addEventListenerstatus === QueryStatus.initializedwere getting rewritten to=== "initialized"every time. The TS enum got runtime-compiled, but was unused. Added equivalent string constants, so the enum is now used for type-checks, but the constants are used for runtime comparisons.context.endpointDefinitions[endpointName], some action meta fields, promise ref unsubscribes)This looks like it knocks about 600 bytes minified off of the RTKQ core artifact, and another 200 bytes off of the RTKQ React artifact: