Skip to content

Fix TypeError for pubsub-sub-bench tests: add missing result path handler #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TypeError for pubsub-sub-bench tests: add missing result path handler #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions redis_benchmarks_specification/__runner__/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2948,6 +2948,10 @@ def delete_temporary_files(
full_result_path = "{}/{}".format(
temporary_dir_client, local_benchmark_output_filename
)
elif "pubsub-sub-bench" in benchmark_tool:
full_result_path = "{}/{}".format(
temporary_dir_client, local_benchmark_output_filename
)
elif "vector-db-benchmark" in benchmark_tool:
# For vector-db-benchmark, look for summary JSON file
summary_files = [
Expand Down Expand Up @@ -3123,12 +3127,23 @@ def delete_temporary_files(
client_aggregated_results_folder,
local_benchmark_output_filename,
)
logging.info(
"Preserving local results file {} into {}".format(
full_result_path, dest_fpath
# Safety check: ensure full_result_path exists before copying
if full_result_path is None:
logging.error(
f"Cannot preserve results: full_result_path is None for test {test_name}. "
f"This may indicate a missing benchmark tool handler in the result path construction."
)
)
shutil.copy(full_result_path, dest_fpath)
elif not os.path.exists(full_result_path):
logging.error(
f"Cannot preserve results: file does not exist at {full_result_path} for test {test_name}"
)
else:
logging.info(
"Preserving local results file {} into {}".format(
full_result_path, dest_fpath
)
)
shutil.copy(full_result_path, dest_fpath)
overall_result &= test_result

delete_temporary_files(
Expand Down