Address 'no scope' warning #1137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I should test that setting the scope to |
fbricon
force-pushed
the
no-scope-warning
branch
from
5ade2db to
8a6fdb4
Compare
Contributor
|
sending
so I would use |
Contributor
Author
|
I double checked on Windows, and this doesn't fix the problem there, but it also doesn't cause any new problems there. |
Contributor
|
Tested on my mac with :
problem remains, but with:
warnings are gone, and [yaml] section settings are still picked up. |
Contributor
Author
|
I'll try it on Windows and push the change if it works |
datho7561
force-pushed
the
no-scope-warning
branch
from
8a6fdb4 to
79ec697
Compare
A scope should be provided when accessing `[xml]` settings, otherwise a warning is emitted. This change provides `file:///` as the scope. Fixes redhat-developer/vscode-yaml#972 Signed-off-by: David Thompson <davthomp@redhat.com>
fbricon
force-pushed
the
no-scope-warning
branch
from
79ec697 to
534776b
Compare
Contributor
|
thanks @datho7561 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A scope should be provided when accessing
[yml]settings, otherwise a warning is emitted. This change providesfile:///as the scope.What issues does this PR fix or reference?
Fixes redhat-developer/vscode-yaml#972
Is it tested? How?
Yes; verified manually that the warning goes away in VS Code.