fix: @ConfigProperty for java.util.Duration with defaultValue flagged as error #1366
+54
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
duration_config_validator
branch
from
2a285f9 to
b5e1c78
Compare
angelozerr
changed the title
angelozerr
changed the title
angelozerr
force-pushed
the
duration_config_validator
branch
from
b5e1c78 to
c4c80e8
Compare
Contributor
|
this doesn't address all quarkus cases, which uses a DurationConverter. See #1207 (comment) |
error Fixes redhat-developer#1207 Signed-off-by: azerr <azerr@redhat.com>
angelozerr
force-pushed
the
duration_config_validator
branch
from
c4c80e8 to
3301cdd
Compare
|
Contributor
Author
|
Fixed with #1520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: @ConfigProperty for java.util.Duration with defaultValue flagged as error
Fixes #1207 and enum (see redhat-developer/vscode-quarkus#612)