Skip to content

Conversation

@jiridanek
Copy link
Member

@jiridanek jiridanek commented Nov 17, 2025

edit

Description

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- Added `workflow_name` parameter for better identification.
- Refined tools and removed redundant commands (`gh pr view` and `gh pr diff`).
- Enhanced documentation and prompt formatting.
@openshift-ci openshift-ci bot requested review from atheo89 and daniellutz November 17, 2025 12:27
@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andyatmiami for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

🤖 Hi @jiridanek, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@github-actions
Copy link

🤖 Hi @jiridanek, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

1 similar comment
@github-actions
Copy link

🤖 Hi @jiridanek, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@github-actions
Copy link

🤖 Hi @jiridanek, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@github-actions
Copy link

🤖 I'm sorry @jiridanek, but I was unable to process your request. Please see the logs for more details.

@jiridanek
Copy link
Member Author

@gemini-cli /review

@jiridanek jiridanek closed this Nov 17, 2025
@jiridanek jiridanek reopened this Nov 17, 2025
@jiridanek jiridanek closed this Nov 17, 2025
@jiridanek jiridanek reopened this Nov 17, 2025
@github-actions
Copy link

🤖 Hi @jiridanek, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@github-actions
Copy link

🤖 I'm sorry @jiridanek, but I was unable to process your request. Please see the logs for more details.

@jiridanek
Copy link
Member Author

@gemini-cli /review

@jiridanek jiridanek self-assigned this Nov 19, 2025
@jiridanek jiridanek marked this pull request as draft November 19, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants