RHAIENG-389: Remove RStudio buildconfig, then add new imagestreams to kustomization #1695
Conversation
|
@atheo89 can you please advise on this change? I am not quiet family with this.
|
|
/build-konflux |
|
we need to have the images built first, otherwise https://github.com/red-hat-data-services/notebooks/actions/runs/19319339147/job/55257304132?pr=1695 so, for now let's please /hold |
atheo89
left a comment
atheo89
left a comment
There was a problem hiding this comment.
Hey Vath, looks we are close to deliver RStudio!
I added some small request changes, please take a look once you have the chance
| opendatahub.io/notebook-image-url: "https://github.com/red-hat-data-services/notebooks/tree/main/rstudio" | ||
| opendatahub.io/notebook-image-name: "RStudio | Minimal | CUDA | R 4.5" | ||
| opendatahub.io/notebook-image-desc: "RStudio Server Workbench image with an integrated development environment for R, a programming language designed for statistical computing and graphics." | ||
| opendatahub.io/recommended-accelerators: '["nvidia.com/gpu"]' |
There was a problem hiding this comment.
We should add also this annotation:
opendatahub.io/notebook-image-order: "22"
But need to check what is the proper number for downstream.
(The same for the rstudio-imagestream.yaml)
There was a problem hiding this comment.
Added opendatahub.io/notebook-image-order: "22"
| ] | ||
| openshift.io/imported-from: quay.io/modh/cuda-rstudio | ||
| opendatahub.io/workbench-image-recommended: 'true' | ||
| opendatahub.io/default-image: "true" |
There was a problem hiding this comment.
This should be removed. That annotation applies only on minimal notebook.
(The same for the rstudio-imagestream.yaml)
There was a problem hiding this comment.
I assumed to remove these 3 lines?
opendatahub.io/workbench-image-recommended: 'true'
opendatahub.io/default-image: "true"
opendatahub.io/notebook-build-commit: odh-workbench-rstudio-cuda-r45-py312-ubi9-commit-n_PLACEHOLDER
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ysok
force-pushed
the
RHAIENG-389-remove-manifest-rhds
branch
from
fa84238 to
7db73c2
Compare
|
New changes are detected. LGTM label has been removed. |
|
@ysok: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Description
RHAIENG-389: Remove RStudio buildconfig, then add new imagestreams to kustomization
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: