-
Notifications
You must be signed in to change notification settings - Fork 24
RHAIENG-1603: Introduce new build-args for konflux build #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHAIENG-1603: Introduce new build-args for konflux build #1668
Conversation
|
Skipping CI for Draft Pull Request. |
atheo89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Vath, these changes look good. However, these files are synced from konflux-central this is the notebooks builds folder.
Once we decide on the RHOAI version to apply them to, we can update the files directly there (in the RHOAI release branch and main), and then sync them back here.
|
@atheo89 does that mean I have to submit another PR to konflux-central for .tekton/* ? And does it get synced manually/automatically? |
|
@ysok exactly. Looks after the push commit the changes sync automatically on the components repo. For more details check here: https://github.com/red-hat-data-services/notebooks/blob/rhoai-3.0/.tekton/README.md |
63192e2 to
4584945
Compare
…ween ODH vs. RHOAI
4584945 to
4c1896b
Compare
|
This PR is good to merge, the konflux.*.conf files are here in repository, but won't get used until I made changes to .tekton files in konflux-central repository. I'll create another separate PR for konflux-central, and it should sync .tekton files back to this repos, so it can make used of this konflux.*.conf |
|
@ysok: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm Thanks Vath! Do you have perms to merge the PR? |
RHAIENG-1603: Introduce new build-args for konflux build
Description
To minimize code conflicts between Dockerfile.* and Dockerfile.konflux., and to avoid having specific changes for Konflux, we can customize those changes into build-args. These build-args can be clearly separated between upstream and downstream build arguments. By doing so, Dockerfile.konflux. will become more similar to the original upstream Dockerfile., while still having their own specific parameters defined separately in their own build-args/.conf.
How Has This Been Tested?
gmake test => ✅ All Dockerfiles are in sync.
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: