Skip to content

Conversation

@daniellutz
Copy link

Fix PyTorch ROCm failing tests.

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@daniellutz
Copy link
Author

/approve

@jiridanek jiridanek changed the title Fix PyTorch ROCm 6.3 tests RHAIENG-1512 : fix(make/test): PyTorch ROCm 6.3 tests Oct 18, 2025
@jiridanek jiridanek changed the title RHAIENG-1512 : fix(make/test): PyTorch ROCm 6.3 tests RHAIENG-1512: fix(make/test): PyTorch ROCm 6.3 tests Oct 18, 2025
Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no legitimate reason why the versions in test_main.py should diverge between odh-io and rhds. The need to make special modifications to the test in rhds shows that we have some version skew in rhds.

That is a bug, because it means that odh-io and rhds have became diverging streams of work, instead of odh-io being a true midstream, that is, area where we prepare upcoming RHOAI releases.

I'm going to redo

work in odh-io, and that should put both into alignment again.

opendatahub-io#2597

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daniellutz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved label Oct 18, 2025
@jiridanek
Copy link
Member

No changes in this PR compared to current main, after ^^^.

@jiridanek jiridanek self-requested a review October 18, 2025 14:16
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2025

@daniellutz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images e4f5e67 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants