-
Notifications
You must be signed in to change notification settings - Fork 139
UI/fix projects section mobile #1206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
UI/fix projects section mobile #1206
Conversation
|
@yashksaini-coder is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
✅ Synchronized metadata from Issue #937:
|
Adez017
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kindly fix
…ng iframe support for live previews, and refining the UI with improved animations and styles.
|
✅ Synchronized metadata from Issue #937:
|
Adez017
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can see the bug still exist for the two projects listed :
@Adez017 could U drop a recording with bug description, Image is not properly highlighting it. |
|
here is the clip : @yashksaini-coder bug_yash.mp4 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@yashksaini-coder , any updates on this |
|
✅ Synchronized metadata from Issue #937:
|
screen-capture.webmI've checked the links, ML project link was outdated, updated that. It should be working now also the overlay UI bug is also fixed. |
i think it looks good to go @yashksaini-coder @sanjay-kv :) |
|
@Adez017 isnt the old ui better ? |
There were some outdated links and an overlay area that was not acting properly on mobile breakpoints |
we can consider this one @sanjay-kv |



Description
This pull request refactors and modernizes the
OurProjectscomponent and its mobile CSS to improve responsiveness, accessibility, and maintainability. The changes include a migration to a data-driven approach, removal of legacy props and types, significant UI/UX enhancements for mobile and tablet devices, and code simplification. The most important changes are grouped below.These changes collectively make the
OurProjectsshowcase more maintainable, performant, and user-friendly across all device sizes.Fixes #937
Type of Change
Changes Made
Component Refactoring & Data Handling:
src/database/projects/projects), removing deprecated props and interfaces for cleaner, more maintainable code. (src/components/ourProjects.tsx, [1] [2]src/components/ourProjects.tsx, src/components/ourProjects.tsxL28-L97)UI/UX & Accessibility Improvements:
src/components/ourProjects.mobile.css, [1] [2] [3]src/components/ourProjects.tsx, [1] [2]Visual & Responsive Enhancements:
src/components/ourProjects.tsx, [1] [2] [3] [4] [5]src/components/ourProjects.tsx, [1] [2]Code Simplification & Cleanup:
src/components/ourProjects.tsx, [1] [2]Mobile CSS Optimization:
src/components/ourProjects.mobile.css, [1] [2]Dependencies
Checklist
npm run buildand attached screenshot(s) in this PR.@Adez017 @sanjay-kv Please review this and let me know