Merge pull request #100 from vipulnsward/100-fix-warnings

Fix warnings

Author: zpao

Rakefile

@@ -14,6 +14,7 @@ Rake::TestTask.new(:test) do |t|
   t.libs << 'test'
   t.pattern = ENV['TEST_PATTERN'] || 'test/**/*_test.rb'
   t.verbose = ENV['TEST_VERBOSE'] == '1'
+  t.warning = true
 end
 
 task default: :test

test/dummy/config/boot.rb

@@ -1,5 +1,5 @@
 # Set up gems listed in the Gemfile.
 ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../Gemfile', __FILE__)
 
-require 'bundler/setup' if File.exists?(ENV['BUNDLE_GEMFILE'])
+require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])
 $LOAD_PATH.unshift File.expand_path('../../../../lib', __FILE__)

test/react_renderer_test.rb

@@ -4,8 +4,8 @@ class ReactRendererTest < ActiveSupport::TestCase
 
   test 'Server rendering class directly' do
     result = React::Renderer.render "TodoList", :todos => %w{todo1 todo2 todo3}
-    assert_match /todo1.*todo2.*todo3/, result
-    assert_match /data-react-checksum/, result
+    assert_match(/todo1.*todo2.*todo3/, result)
+    assert_match(/data-react-checksum/, result)
   end
 
   test 'Server rendering with an already-encoded json string' do
@@ -14,8 +14,8 @@ class ReactRendererTest < ActiveSupport::TestCase
     end.target!
 
     result = React::Renderer.render "TodoList", json_string
-    assert_match /todo1.*todo2.*todo3/, result
-    assert_match /data-react-checksum/, result
+    assert_match(/todo1.*todo2.*todo3/, result)
+    assert_match(/data-react-checksum/, result)
   end
 
   test 'Rendering does not throw an exception when console log api is used' do

test/view_helper_test.rb

@@ -94,14 +94,14 @@ class ViewHelperTest < ActionDispatch::IntegrationTest
 
   test 'react server rendering also gets mounted on client' do
     visit '/server/1'
-    assert_match /data-react-class=\"TodoList\"/, page.html
-    assert_match /data-react-checksum/, page.html
-    assert_match /yep/, page.find("#status").text
+    assert_match(/data-react-class=\"TodoList\"/, page.html)
+    assert_match(/data-react-checksum/, page.html)
+    assert_match(/yep/, page.find("#status").text)
   end
 
   test 'react server rendering does not include internal properties' do
     visit '/server/1'
-    assert_no_match /tag=/, page.html
-    assert_no_match /prerender=/, page.html
+    assert_no_match(/tag=/, page.html)
+    assert_no_match(/prerender=/, page.html)
   end
 end