Skip to content

Commit 72c5078

Browse files
committed
- Fixed react renderer and view helper to not throw ambiguous arguments warnings, when asserting data using regex arguements.
1 parent 007ef9f commit 72c5078

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

test/react_renderer_test.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ class ReactRendererTest < ActiveSupport::TestCase
44

55
test 'Server rendering class directly' do
66
result = React::Renderer.render "TodoList", :todos => %w{todo1 todo2 todo3}
7-
assert_match /todo1.*todo2.*todo3/, result
8-
assert_match /data-react-checksum/, result
7+
assert_match(/todo1.*todo2.*todo3/, result)
8+
assert_match(/data-react-checksum/, result)
99
end
1010

1111
test 'Server rendering with an already-encoded json string' do
@@ -14,8 +14,8 @@ class ReactRendererTest < ActiveSupport::TestCase
1414
end.target!
1515

1616
result = React::Renderer.render "TodoList", json_string
17-
assert_match /todo1.*todo2.*todo3/, result
18-
assert_match /data-react-checksum/, result
17+
assert_match(/todo1.*todo2.*todo3/, result)
18+
assert_match(/data-react-checksum/, result)
1919
end
2020

2121
test 'Rendering does not throw an exception when console log api is used' do

test/view_helper_test.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,14 +94,14 @@ class ViewHelperTest < ActionDispatch::IntegrationTest
9494

9595
test 'react server rendering also gets mounted on client' do
9696
visit '/server/1'
97-
assert_match /data-react-class=\"TodoList\"/, page.html
98-
assert_match /data-react-checksum/, page.html
99-
assert_match /yep/, page.find("#status").text
97+
assert_match(/data-react-class=\"TodoList\"/, page.html)
98+
assert_match(/data-react-checksum/, page.html)
99+
assert_match(/yep/, page.find("#status").text)
100100
end
101101

102102
test 'react server rendering does not include internal properties' do
103103
visit '/server/1'
104-
assert_no_match /tag=/, page.html
105-
assert_no_match /prerender=/, page.html
104+
assert_no_match(/tag=/, page.html)
105+
assert_no_match(/prerender=/, page.html)
106106
end
107107
end

0 commit comments

Comments
 (0)