Shovel: self-contained shovel protocols #14904
Merged
+710
−591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor protocol parsing & validation into their own modules rabbit_shovel_behaviour is now a registry class, thus any new protocol can add itself dinamically and is self-contained
It needs the rabbit registry to select the protocols
michaelklishin
approved these changes
Nov 10, 2025
dcorbacho
added a commit
that referenced
this pull request
Nov 10, 2025
Shovel: self-contained shovel protocols (backport #14904)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor protocol parsing & validation into their own modules rabbit_shovel_behaviour is now a registry class, thus any new protocol can add itself dynamically to the registry, and every protocol module is now "self-contained" in the sense that includes all protocol-specific runtime parameter parsing.