DO NOT MERGE Remove CQv1 #14769
Draft
DO NOT MERGE Remove CQv1 #14769
+401
−2,579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was only used by CMQs and they have been removed a while back.
lhoguin
commented
Nov 4, 2025
| %% @todo This can be heavily simplified: if the message falls into delta, | ||
| %% add it there. Otherwise just add it to q3 in the correct position. | ||
| %% @todo I think if the message falls within Q3 we must add it back there, | ||
| %% otherwise there's nothing to do? Except update stats. |
| St#vqstate{?UP(len, ram_msg_count, +1), | ||
| ?UP(bytes, +msg_size(MS)), ?UP(unacked_bytes, -msg_size(MS))}. | ||
|
|
||
| %% TODO!!! |
| sets:union(MOD, Confirmed) }) | ||
| end). | ||
|
|
||
| %% @todo Having to call run_backing_queue is probably reducing performance... |
| %% queue implementation itself. | ||
| -export([pre_publish/7, flush_pre_publish_cache/2, | ||
| sync/1, needs_sync/1, flush/1, | ||
| %% @todo TODO |
We avoid an extra unnecessary message to the queue.
And drop all terminology from antique CQ. Some terminology remains in the backing_queue_SUITE, to be addressed later.
These metrics make a lot less sense in today's CQ implementation. Today messages are either in memory about to be sent to the consumer, or on disk because they are further down the queue. Messages are no longer paged out to disk depending on memory pressure. So knowing how many transient messages are on disk is not as important. In practice almost all of them will be.
It duplicates the ?QUEUE:len and the #q_tail.count which together provide the same value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.