feat: activity status is set in error

Author: aygalinc

projects/RabbitMQ.Client/Impl/Connection.cs

@@ -251,6 +251,7 @@ await _channel0.ConnectionOpenAsync(_config.VirtualHost, cancellationToken)
             }
             catch (Exception ex)
             {
+                connectionActivity?.SetStatus(ActivityStatusCode.Error);
                 connectionActivity?.AddException(ex);
                 try
                 {

projects/Test/Common/ActivityRecorder.cs

@@ -123,7 +123,7 @@ public Activity VerifyActivityRecordedOnce()
 
     public static class ActivityAssert
     {
-        public static KeyValuePair<string, object> HasTag(Activity activity, string name)
+        public static KeyValuePair<string, object> HasTag(this Activity activity, string name)
         {
             KeyValuePair<string, object> tag = activity.TagObjects.SingleOrDefault(t => t.Key == name);
             if (tag.Key is null)
@@ -134,7 +134,7 @@ public static KeyValuePair<string, object> HasTag(Activity activity, string name
             return tag;
         }
 
-        public static void HasTag<T>(Activity activity, string name, T expectedValue)
+        public static void HasTag<T>(this Activity activity, string name, T expectedValue)
         {
             KeyValuePair<string, object> tag = HasTag(activity, name);
             Assert.Equal(expectedValue, (T)tag.Value);
@@ -147,14 +147,19 @@ public static void HasRecordedException(this Activity activity, Exception except
             Assert.Equal(exception.GetType().ToString(),
                 exceptionEvent.Tags.SingleOrDefault(t => t.Key == "exception.type").Value);
         }
+        
+        public static void IsInError(this Activity activity)
+        {
+            Assert.Equal(ActivityStatusCode.Error, activity.Status);
+        }
 
-        public static void HasNoTag(Activity activity, string name)
+        public static void HasNoTag(this Activity activity, string name)
         {
             bool contains = activity.TagObjects.Any(t => t.Key == name);
             Assert.False(contains, $"The Activity tags should not contain {name}.");
         }
 
-        public static void FinishedInOrder(Activity first, Activity second)
+        public static void FinishedInOrder(this Activity first, Activity second)
         {
             Assert.True(first.StartTimeUtc + first.Duration < second.StartTimeUtc + second.Duration,
                 $"{first.OperationName} should stop before {second.OperationName}");

projects/Test/Integration/TestConnectionFactory.cs

@@ -462,6 +462,7 @@ public async Task TestCreateConnectionWithFailureRecordException()
             });
             Activity activity = recorder.VerifyActivityRecordedOnce();
             activity.HasRecordedException(exception);
+            activity.IsInError();
         }
     }
 }