feat: ensure exception is recorded

Author: aygalinc

projects/Test/Common/ActivityRecorder.cs

@@ -130,6 +130,7 @@ public static KeyValuePair<string, object> HasTag(Activity activity, string name
             {
                 Assert.Fail($"The Activity tags should contain {name}.");
             }
+
             return tag;
         }
 
@@ -139,6 +140,14 @@ public static void HasTag<T>(Activity activity, string name, T expectedValue)
             Assert.Equal(expectedValue, (T)tag.Value);
         }
 
+        public static void HasRecordedException(this Activity activity, Exception exception)
+        {
+            var exceptionEvent = activity.Events.First();
+            Assert.Equal("exception", activity.Events.First().Name);
+            Assert.Equal(exception.GetType().ToString(),
+                exceptionEvent.Tags.SingleOrDefault(t => t.Key == "exception.type").Value);
+        }
+
         public static void HasNoTag(Activity activity, string name)
         {
             bool contains = activity.TagObjects.Any(t => t.Key == name);
@@ -147,7 +156,8 @@ public static void HasNoTag(Activity activity, string name)
 
         public static void FinishedInOrder(Activity first, Activity second)
         {
-            Assert.True(first.StartTimeUtc + first.Duration < second.StartTimeUtc + second.Duration, $"{first.OperationName} should stop before {second.OperationName}");
+            Assert.True(first.StartTimeUtc + first.Duration < second.StartTimeUtc + second.Duration,
+                $"{first.OperationName} should stop before {second.OperationName}");
         }
 
         public static string CamelToSnake(string camel)
@@ -162,8 +172,10 @@ public static string CamelToSnake(string camel)
                 {
                     bld.Append('_');
                 }
+
                 bld.Append(char.ToLower(c));
             }
+
             return bld.ToString();
         }
     }

projects/Test/Integration/TestConnectionFactory.cs

@@ -444,8 +444,24 @@ public async Task TestCreateConnectionRegisterAnActivity()
             ConnectionFactory cf = CreateConnectionFactory();
             await using IConnection conn = await cf.CreateConnectionAsync();
             recorder.VerifyActivityRecordedOnce();
-            
             await conn.CloseAsync();
         }
+        
+        [Fact]
+        public async Task TestCreateConnectionWithFailureRecordException()
+        {
+            using ActivityRecorder recorder =
+                new ActivityRecorder(RabbitMQActivitySource.ConnectionSourceName, "connection attempt");
+            ConnectionFactory cf = CreateConnectionFactory();
+            cf.AutomaticRecoveryEnabled = true;
+            var unreachablePort = 1234;
+            var ep = new AmqpTcpEndpoint("localhost", unreachablePort);
+            var exception = await Assert.ThrowsAsync<BrokerUnreachableException>(() =>
+            {
+                return cf.CreateConnectionAsync(new List<AmqpTcpEndpoint> { ep });
+            });
+            Activity activity = recorder.VerifyActivityRecordedOnce();
+            activity.HasRecordedException(exception);
+        }
     }
 }