* Remove ConfirmSelectAsync and move code into dedicated pub conf file.

Author: lukebakken

projects/RabbitMQ.Client/Impl/Channel.PublisherConfirms.cs

@@ -30,8 +30,10 @@
 //---------------------------------------------------------------------------
 
 using System.Collections.Concurrent;
+using System.Diagnostics;
 using System.Threading;
 using System.Threading.Tasks;
+using RabbitMQ.Client.Framing;
 
 namespace RabbitMQ.Client.Impl
 {
@@ -55,8 +57,39 @@ private async Task MaybeConfirmSelect(CancellationToken cancellationToken)
         {
             if (_publisherConfirmationsEnabled)
             {
-                await ConfirmSelectAsync(_publisherConfirmationTrackingEnabled, cancellationToken)
-                    .ConfigureAwait(false);
+                // NOTE: _rpcSemaphore is held
+                bool enqueued = false;
+                var k = new ConfirmSelectAsyncRpcContinuation(ContinuationTimeout, cancellationToken);
+
+                try
+                {
+                    if (_nextPublishSeqNo == 0UL)
+                    {
+                        if (_publisherConfirmationTrackingEnabled)
+                        {
+                            _confirmsTaskCompletionSources.Clear();
+                        }
+                        _nextPublishSeqNo = 1;
+                    }
+
+                    enqueued = Enqueue(k);
+
+                    var method = new ConfirmSelect(false);
+                    await ModelSendAsync(in method, k.CancellationToken)
+                        .ConfigureAwait(false);
+
+                    bool result = await k;
+                    Debug.Assert(result);
+
+                    return;
+                }
+                finally
+                {
+                    if (false == enqueued)
+                    {
+                        k.Dispose();
+                    }
+                }
             }
         }
     }

projects/RabbitMQ.Client/Impl/Channel.cs

@@ -1716,47 +1716,6 @@ await ModelSendAsync(in method, k.CancellationToken)
             }
         }
 
-        // NOTE: _rpcSemaphore is held
-        private async Task ConfirmSelectAsync(bool publisherConfirmationTrackingEnablefd = false,
-            CancellationToken cancellationToken = default)
-        {
-            _publisherConfirmationsEnabled = true;
-            _publisherConfirmationTrackingEnabled = publisherConfirmationTrackingEnablefd;
-
-            bool enqueued = false;
-            var k = new ConfirmSelectAsyncRpcContinuation(ContinuationTimeout, cancellationToken);
-
-            try
-            {
-                if (_nextPublishSeqNo == 0UL)
-                {
-                    if (_publisherConfirmationTrackingEnabled)
-                    {
-                        _confirmsTaskCompletionSources.Clear();
-                    }
-                    _nextPublishSeqNo = 1;
-                }
-
-                enqueued = Enqueue(k);
-
-                var method = new ConfirmSelect(false);
-                await ModelSendAsync(in method, k.CancellationToken)
-                    .ConfigureAwait(false);
-
-                bool result = await k;
-                Debug.Assert(result);
-
-                return;
-            }
-            finally
-            {
-                if (false == enqueued)
-                {
-                    k.Dispose();
-                }
-            }
-        }
-
         private Task HandleAck(ulong deliveryTag, bool multiple, CancellationToken cancellationToken = default)
         {
             if (_publisherConfirmationsEnabled && _publisherConfirmationTrackingEnabled && deliveryTag > 0 && !_confirmsTaskCompletionSources.IsEmpty)