* Refactor Channel.OpenAsync to move pub conf code to dedicated file.

Author: lukebakken

projects/RabbitMQ.Client/Impl/Channel.PublisherConfirms.cs

@@ -44,5 +44,20 @@ internal partial class Channel : IChannel, IRecoverable
         private ulong _nextPublishSeqNo = 0;
         private readonly SemaphoreSlim _confirmSemaphore = new(1, 1);
         private readonly ConcurrentDictionary<ulong, TaskCompletionSource<bool>> _confirmsTaskCompletionSources = new();
+
+        private void ConfigurePublisherConfirmations(bool publisherConfirmationsEnabled, bool publisherConfirmationTrackingEnabled)
+        {
+            _publisherConfirmationsEnabled = publisherConfirmationsEnabled;
+            _publisherConfirmationTrackingEnabled = publisherConfirmationTrackingEnabled;
+        }
+
+        private async Task MaybeConfirmSelect(CancellationToken cancellationToken)
+        {
+            if (_publisherConfirmationsEnabled)
+            {
+                await ConfirmSelectAsync(_publisherConfirmationTrackingEnabled, cancellationToken)
+                    .ConfigureAwait(false);
+            }
+        }
     }
 }

projects/RabbitMQ.Client/Impl/Channel.cs

@@ -367,8 +367,7 @@ internal async Task<IChannel> OpenAsync(bool publisherConfirmationsEnabled = fal
             bool publisherConfirmationTrackingEnabled = false,
             CancellationToken cancellationToken = default)
         {
-            _publisherConfirmationsEnabled = publisherConfirmationsEnabled;
-            _publisherConfirmationTrackingEnabled = publisherConfirmationTrackingEnabled;
+            ConfigurePublisherConfirmations(publisherConfirmationsEnabled, publisherConfirmationTrackingEnabled);
 
             bool enqueued = false;
             var k = new ChannelOpenAsyncRpcContinuation(ContinuationTimeout, cancellationToken);
@@ -386,11 +385,8 @@ await ModelSendAsync(in method, k.CancellationToken)
                 bool result = await k;
                 Debug.Assert(result);
 
-                if (_publisherConfirmationsEnabled)
-                {
-                    await ConfirmSelectAsync(publisherConfirmationTrackingEnabled, cancellationToken)
-                        .ConfigureAwait(false);
-                }
+                await MaybeConfirmSelect(cancellationToken)
+                    .ConfigureAwait(false);
             }
             finally
             {