[Test]: Models test configs in a single Config file #596
+703
−729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abukhoy
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
quic-rishinr
requested changes
Nov 4, 2025
| # assert (pytorch_kv_tokens == pytorch_hf_tokens).all(), ( | ||
| # "Tokens don't match for pytorch HF output and pytorch KV output" | ||
| # ) | ||
| qeff_model = QEFFAutoModelForImageTextToText(model_hf, kv_offload=kv_offload) |
Contributor
There was a problem hiding this comment.
We should still maintain the check for pytorch kv vs pytorch hf, I think its commented because of some models we are not able to run the hf directly, we should skip the test only for those models, Can you check on this and add it back
| qeff_model = QEFFAutoModelForImageTextToText(model_hf, kv_offload=kv_offload) | ||
|
|
||
| qeff_model.export() | ||
| # onnx_model_path = qeff_model.export() |
Contributor
There was a problem hiding this comment.
keep the onnx test also do not remove it as we might enable it back in future
| ): | ||
| @pytest.mark.parametrize("model_name", test_intern_models) | ||
| @pytest.mark.parametrize("kv_offload", [True, False]) | ||
| def test_image_text_to_text_intern_pytorch_vs_kv_vs_ort_vs_ai100(model_name, kv_offload): |
Contributor
There was a problem hiding this comment.
Can we unify the intern with other vlms?
Contributor
Author
|
Hi @quic-rishinr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created for combining all the testing model configs in a single config json file.