Skip to content

Conversation

@fegin
Copy link
Contributor

@fegin fegin commented Nov 12, 2025

Stack from ghstack (oldest at bottom):

The current CompileModule will result in an "inner" prefix for everything. This
PR fixes it by overloading the methods.

Also merge #2028 to this PR. Something wrong with ghstack.

[ghstack-poisoned]
[ghstack-poisoned]
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 12, 2025
@fegin fegin changed the title Make compiler toolkit works with checkpoint [Compiler Toolkit] Make compiler toolkit works with checkpoint Nov 12, 2025
@fegin fegin changed the title [Compiler Toolkit] Make compiler toolkit works with checkpoint [Compiler Toolkit] Make compiler toolkit work with checkpoint Nov 12, 2025
fegin added a commit that referenced this pull request Nov 13, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.12.0)
(oldest at bottom):
* #2029
* #2030
* #2028
* #2027
* __->__ #2026

As title
fegin added a commit that referenced this pull request Nov 13, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.12.0)
(oldest at bottom):
* #2029
* #2030
* #2028
* __->__ #2027
* #2026

Dry run mode works but it doesn't exit gracefully for all cases. This PR
fixes it

```
DRY_RUN=1 CONFIG_FILE="./torchtitan/models/llama3/train_configs/debug_model.toml" ./run_train.sh   --training.steps=10 --activation_checkpoint.mode="none"
--debug.deterministic --debug.seed=42
```
[ghstack-poisoned]
[ghstack-poisoned]
@fegin fegin changed the base branch from gh/fegin/39/base to main November 13, 2025 08:09
@fegin fegin changed the base branch from main to gh/fegin/39/base November 13, 2025 08:10
[ghstack-poisoned]
[ghstack-poisoned]
@fegin fegin changed the base branch from gh/fegin/39/base to main November 13, 2025 08:19
@fegin fegin merged commit e7ee95a into main Nov 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants