Skip to content

Commit 6a4f7ed

Browse files
r-barnesfacebook-github-bot
authored andcommitted
Remove unused variables in gloo/rendezvous/redis_store.cc
Summary: LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: danzimm Differential Revision: D52848007 fbshipit-source-id: 58693326dda966d9496635ef292e3a768ea26672
1 parent e6c13da commit 6a4f7ed

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

gloo/rendezvous/redis_store.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
namespace gloo {
1818
namespace rendezvous {
1919

20-
static const std::chrono::seconds kWaitTimeout = std::chrono::seconds(60);
21-
2220
RedisStore::RedisStore(const std::string& host, int port) {
2321
struct timeval timeout = {.tv_sec = 2};
2422
redis_ = redisConnectWithTimeout(host.c_str(), port, timeout);

0 commit comments

Comments
 (0)