Fix shadowed variable in gloo/barrier.h

Summary:
Our upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.

This codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.

**What's a shadowed variable?**

Shadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.

This diff fixes such an issue by renaming the variable.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: palmje

Differential Revision: D52582817

fbshipit-source-id: f7d7cd3123804c0c11b0f2d38de1b7535cd48e00

Author: r-barnes

gloo/barrier.h

@@ -26,12 +26,12 @@ class BarrierOptions {
  public:
   explicit BarrierOptions(const std::shared_ptr<Context>& context);
 
-  void setTag(uint32_t tag) {
-    this->tag = tag;
+  void setTag(uint32_t tag_2) {
+    this->tag = tag_2;
   }
 
-  void setTimeout(std::chrono::milliseconds timeout) {
-    this->timeout = timeout;
+  void setTimeout(std::chrono::milliseconds timeout_2) {
+    this->timeout = timeout_2;
   }
 
  protected: