[python-dateutil] add some more missing paramater type annotations #14996
+17
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
donBarbos
suggested changes
Nov 8, 2025
| def __init__(self, tzres_loc="tzres.dll"): ... | ||
| def load_name(self, offset): ... | ||
| def name_from_string(self, tzname_str: str): ... | ||
| def __init__(self, tzres_loc: str = "tzres.dll") -> None: ... |
Contributor
There was a problem hiding this comment.
It might be worth using a type that ctypes.WinDLL() accepts inside (_NameTypes is type alias from ctypes),
and attribute could be specified right away:
Suggested change
| def __init__(self, tzres_loc: str = "tzres.dll") -> None: ... | |
| tzres_loc: _NameTypes | |
| def __init__(self, tzres_loc: _NameTypes = "tzres.dll") -> None: ... |
|
|
||
| def rebuild(filename: StrOrBytesPath, tag=None, format: str = "gz", zonegroups: Iterable[str] = [], metadata=None) -> None: ... | ||
| def rebuild( | ||
| filename: StrOrBytesPath, tag=None, format: str = "gz", zonegroups: Iterable[str] = [], metadata: dict[str, Any] | None = None |
Contributor
There was a problem hiding this comment.
I think Incomplete is more appropriate here since it is used for the return type from gettz_db_metadata
and if _MetadataType (type alias to dict[str, Incomplete]) is changed to TypedDict, it will be changed at the same time
Suggested change
| filename: StrOrBytesPath, tag=None, format: str = "gz", zonegroups: Iterable[str] = [], metadata: dict[str, Any] | None = None | |
| filename: StrOrBytesPath, tag=None, format: str = "gz", zonegroups: Iterable[str] = [], metadata: _MetadataType | None = None |
Contributor
|
Thank you! Few nits above |
Contributor
Author
|
Thanks for the great suggestions! |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things I missed in #14992